Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for app engine flexible app version #5025

Comments

@jackap
Copy link

jackap commented Dec 2, 2019

Community Note

I am asking this here because I did not find any resource online

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

It would be good to have the possiblity of introducing flexible applications in app engine. At the moment this is not possible. The only supported resource is: google_app_engine_standard_app_version. One solution could be adding a new resource or refactoring the existing one so that one could specify the type of application.

New or Affected Resource(s)

The new resource name might be:

  • google_app_engine_flex_app_version

Potential Terraform Configuration

resource "google_app_engine_flex_app_version" "myapp_v1" {
  version_id = "v1"
  service    = "myapp"
  runtime    = "nodejs10"

  entrypoint {
    shell = "node ./app.js"
  }

  deployment {
    zip {
      source_url = "https://storage.googleapis.com/${google_storage_bucket.bucket.name}/${google_storage_bucket_object.object.name}"
    }
  }

  env_variables = {
    port = "8080"
  }

  delete_service_on_destroy = true
}

References

https://www.terraform.io/docs/providers/google/r/app_engine_standard_app_version.html

  • #0000
@ghost ghost added the enhancement label Dec 2, 2019
@danawillow danawillow added this to the Near-Term Goals milestone Dec 2, 2019
@danawillow danawillow modified the milestones: Near-Term Goals, Sprint 6 Jan 27, 2020
@megan07 megan07 self-assigned this Feb 3, 2020
@dlee
Copy link

dlee commented Feb 11, 2020

Please support custom runtimes to allow running custom Dockerfiles on App Engine: https://cloud.google.com/appengine/docs/flexible/custom-runtimes/about-custom-runtimes?hl=en

Also, please support beta_settings.cloud_sql_instances (https://cloud.google.com/sql/docs/postgres/connect-app-engine) to allow connecting to Cloud SQL for PostgreSQL without VPC.

Screen Shot 2020-02-11 at 10 04 58 AM

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.