Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Tasks max_dispatches_per_second should support floats/doubles #5341

Closed
preston-hf opened this issue Jan 8, 2020 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#2964
Assignees
Labels

Comments

@preston-hf
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.18

  • provider.google v3.4.0
  • provider.google-beta v3.4.0

Affected Resource(s)

  • google_cloud_tasks_queue

Terraform Configuration Files

Expected Behavior

max_dispatches_per_second should support providing doubles.

Actual Behavior

max_dispatches_per_second only supports integers

References

You can see here that the parameter is a double

  • #0000
@ghost ghost added the bug label Jan 8, 2020
@edwardmedia edwardmedia self-assigned this Jan 8, 2020
@edwardmedia
Copy link
Contributor

Here is the response I get from an API call. It appears this field does accept double

HTTP/1.1 200 OK
Content-length: 356
X-xss-protection: 0
X-content-type-options: nosniff
Transfer-encoding: chunked
Vary: Origin, X-Origin, Referer
Server: ESF
-content-encoding: gzip
Cache-control: private
Date: Wed, 08 Jan 2020 22:21:13 GMT
X-frame-options: SAMEORIGIN
Alt-svc: quic=":443"; ma=2592000; v="46,43",h3-Q050=":443"; ma=2592000,h3-Q049=":443"; ma=2592000,h3-Q048=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000
Content-type: application/json; charset=UTF-8
{
  "rateLimits": {
    "maxConcurrentDispatches": 1000, 
    "maxBurstSize": 10, 
    "maxDispatchesPerSecond": 1.1
  }, 
  "state": "RUNNING", 
  "name": "projects/my-project/locations/us-central1/queues/cloud-tasks-queue-test3", 
  "retryConfig": {
    "maxDoublings": 16, 
    "maxAttempts": 100, 
    "maxBackoff": "3600s", 
    "minBackoff": "0.100s"
  }
}

@ghost
Copy link

ghost commented Feb 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants