Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of minNodeCpus #5416

Comments

@dens-github
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Hello,

Sorry for posting that here, but the other terraform-provider-google-beta repo don't allow issue creation.

Google has implemented a new beta API call to set up a minimum of CPUs to be used for sole-tenants instances.
The internal API name seem to be minNodeCpus. The CLI tools the --min-node-cpu option, as can be read in the Google documentation.

The goal of this implementation is to ensure instances (data bases, web servers, etc.) always have a minimum of CPU time allowed to avoid slowness or downtime.

Do you have any roadmap to implement this feature?

Thank you!

New or Affected Resource(s)

  • google_compute_instance

Potential Terraform Configuration

resource "google_compute_instance" "vm_instance" {
  name           = "terraform-instance"
  machine_type   = "n1-standard-8"
  min_node_cpu   = 4 # Would call minNodeCpus API to allow at least four CPUs, not less.
  
  boot_disk {
    initialize_params {
      image = "debian-cloud/debian-9"
    }
  }

  network_interface {
    # A default network is created for all GCP projects
    network       = "default"
    access_config {
    }
  }
}

References

< No GitHub reference >

@ghost ghost added the enhancement label Jan 15, 2020
@dens-github dens-github changed the title Ipmlementation of minNodeCpus Implementation of minNodeCpus Jan 15, 2020
@danawillow danawillow added this to the Goals milestone Jan 21, 2020
@danawillow danawillow removed this from the Goals milestone Jun 10, 2020
@danawillow
Copy link
Contributor

Note that this also needs to be added for instance templates

@ghost
Copy link

ghost commented Jul 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.