Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a "job_id" field for google_dataflow_job #5596

Closed
jcanseco opened this issue Feb 5, 2020 · 4 comments
Closed

Support a "job_id" field for google_dataflow_job #5596

jcanseco opened this issue Feb 5, 2020 · 4 comments
Assignees
Milestone

Comments

@jcanseco
Copy link
Contributor

jcanseco commented Feb 5, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Dataflow Jobs are uniquely identified by their job ID instead of their name. My request is to expose the job ID as a computed field, job_id.

It seems that the Terraform provider is already retrieving the job ID and setting it as the Terraform resource ID as seen here, so exposing it as a computed field should hopefully be reasonably doable.

Furthermore, there is precedence in using a computed identifier as the Terraform resource ID and exposed as a computed field, as seen with the name field of google_firestore_index here.

New or Affected Resource(s)

  • google_dataflow_job
@ghost ghost added the enhancement label Feb 5, 2020
@jeet-parekh
Copy link
Contributor

Can I try to work on this?

@danawillow danawillow added this to the Goals milestone Feb 10, 2020
@danawillow
Copy link
Contributor

Sure! Putting @jeet-parekh as the assignee. Since this is the same value that we already set in the id field, this should be pretty straightforward, but let me know if you have questions.

@jcanseco
Copy link
Contributor Author

Thank you for taking the initiative @jeet-parekh!

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants