Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_network_endpoint_group:network_endpoint_type only lists GCE_VM_IP_PORT, should list 4 more #9531

Closed
glickbot opened this issue Jul 8, 2021 · 2 comments
Assignees
Labels

Comments

@glickbot
Copy link

glickbot commented Jul 8, 2021

I'm not sure if this is just a documentation error, but this says:

network_endpoint_type - (Optional) Type of network endpoints in this network endpoint group. Default value is GCE_VM_IP_PORT. Possible values are GCE_VM_IP_PORT.

When the API docs say:

networkEndpointType enum Type of network endpoints in this network endpoint group. Can be one of GCE_VM_IP_PORT, NON_GCP_PRIVATE_IP_PORT, INTERNET_FQDN_PORT, INTERNET_IP_PORT, or SERVERLESS.

The docs should be updated to include all available options, and make sure there's nothing stopping those options from being used in any validation process, etc.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Affected Resource(s)

  • google_XXXXX

Terraform Configuration Files

# Copy-paste your Terraform configurations here.
#
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.
# For security, you can also encrypt the files using our GPG public key:
#    https://www.hashicorp.com/security
#
# If reproducing the bug involves modifying the config file (e.g., apply a config,
# change a value, apply the config again, see the bug), then please include both:
# * the version of the config before the change, and
# * the version of the config after the change.

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@glickbot glickbot added the bug label Jul 8, 2021
@edwardmedia edwardmedia self-assigned this Jul 13, 2021
@edwardmedia
Copy link
Contributor

@glickbot both are right. By the time the resource was built, only those values were available. Likely api has added more valid values. You could file enhancement and new values will be added in the future

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants