From 382969317bf21930b4d48abda45c1d8a66bc35a5 Mon Sep 17 00:00:00 2001 From: Riley Karson Date: Tue, 29 Oct 2019 20:34:01 +0000 Subject: [PATCH] Add GKE taint changes to the upgrade guide Signed-off-by: Modular Magician --- website/docs/version_3_upgrade.html.markdown | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/website/docs/version_3_upgrade.html.markdown b/website/docs/version_3_upgrade.html.markdown index 201bcc10dce..62a5a1e002e 100644 --- a/website/docs/version_3_upgrade.html.markdown +++ b/website/docs/version_3_upgrade.html.markdown @@ -123,6 +123,23 @@ logging_service = "logging.googleapis.com/kubernetes" monitoring_service = "monitoring.googleapis.com/kubernetes" ``` +### `taint` field is now authoritative when set + +The `taint` field inside of `node_config` blocks on `google_container_cluster` +and `google_container_node_pool` will no longer ignore GPU-related values when +set. + +Previously, the field ignored upstream taints when unset and ignored unset GPU +taints when other taints were set. Now it will ignore upstream taints when set +and act authoritatively when set, requiring all taints (including Kubernetes and +GKE-managed ones) to be defined in config. + +Additionally, an empty taint can now be specified with `taint = []`. As a result +of this change, the JSON/state representation of the field has changed, +introducing an incompatibility for users who specify config in JSON instead of +HCL or who use `dynamic` blocks. See more details in the [Attributes as Blocks](https://www.terraform.io/docs/configuration/attr-as-blocks.html) +documentation. + ## Resource: `google_project_services` ### `google_project_services` has been removed from the provider