provider/azurerm: allow updating load balancer sub-resources #10016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pmcatominey
commented
Nov 10, 2016
pmcatominey
commented
- check if rule is being updated rather than assuming created
- added test to cover guard against multiple rules with the same name
* check if rule is being updated rather than assuming created * added test to cover guard against multiple rules with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerRule_" -timeout 120m === RUN TestAccAzureRMLoadBalancerRule_basic --- PASS: TestAccAzureRMLoadBalancerRule_basic (157.45s) === RUN TestAccAzureRMLoadBalancerRule_removal --- PASS: TestAccAzureRMLoadBalancerRule_removal (163.67s) === RUN TestAccAzureRMLoadBalancerRule_inconsistentReads --- PASS: TestAccAzureRMLoadBalancerRule_inconsistentReads (150.00s) === RUN TestAccAzureRMLoadBalancerRule_update --- PASS: TestAccAzureRMLoadBalancerRule_update (164.20s) === RUN TestAccAzureRMLoadBalancerRule_duplicateRules --- PASS: TestAccAzureRMLoadBalancerRule_duplicateRules (137.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 772.846s
pmcatominey
changed the title
pmcatominey
force-pushed
the
azurerm-lb-rule-update
branch
3 times, most recently
from
ed47c49
to
2ada963
Compare
added 2 commits
November 10, 2016 15:34
* check if NAT rule is being updated rather than assuming created * added test to cover guard against multiple NAT rules with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerNatRule" -timeout 120m === RUN TestAccAzureRMLoadBalancerNatRule_basic --- PASS: TestAccAzureRMLoadBalancerNatRule_basic (148.48s) === RUN TestAccAzureRMLoadBalancerNatRule_removal --- PASS: TestAccAzureRMLoadBalancerNatRule_removal (163.48s) === RUN TestAccAzureRMLoadBalancerNatRule_update --- PASS: TestAccAzureRMLoadBalancerNatRule_update (176.97s) === RUN TestAccAzureRMLoadBalancerNatRule_duplicate --- PASS: TestAccAzureRMLoadBalancerNatRule_duplicate (136.36s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 625.301s
* check if probe is being updated rather than assuming created * added test to cover guard against multiple probes with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerProbe" -timeout 120m === RUN TestAccAzureRMLoadBalancerProbe_basic --- PASS: TestAccAzureRMLoadBalancerProbe_basic (134.53s) === RUN TestAccAzureRMLoadBalancerProbe_removal --- PASS: TestAccAzureRMLoadBalancerProbe_removal (168.06s) === RUN TestAccAzureRMLoadBalancerProbe_update --- PASS: TestAccAzureRMLoadBalancerProbe_update (175.99s) === RUN TestAccAzureRMLoadBalancerProbe_duplicate --- PASS: TestAccAzureRMLoadBalancerProbe_duplicate (139.01s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 617.598s
pmcatominey
force-pushed
the
azurerm-lb-rule-update
branch
5 times, most recently
from
3bf9cde
to
cff4e39
Compare
* check if NAT pool is being updated rather than assuming created * added test to cover guard against multiple NAT pools with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerNatPool" -timeout 120m === RUN TestAccAzureRMLoadBalancerNatPool_basic --- PASS: TestAccAzureRMLoadBalancerNatPool_basic (146.52s) === RUN TestAccAzureRMLoadBalancerNatPool_removal --- PASS: TestAccAzureRMLoadBalancerNatPool_removal (158.34s) === RUN TestAccAzureRMLoadBalancerNatPool_update --- PASS: TestAccAzureRMLoadBalancerNatPool_update (174.05s) === RUN TestAccAzureRMLoadBalancerNatPool_duplicate --- PASS: TestAccAzureRMLoadBalancerNatPool_duplicate (136.94s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 615.866s
pmcatominey
force-pushed
the
azurerm-lb-rule-update
branch
from
cff4e39
to
cb991cd
Compare
pmcatominey
changed the title
|
Updated to cover other affected sub resources, one per commit. |
|
Thanks so much @pmcatominey - this looks great! |
stack72
pushed a commit
that referenced
this pull request
Nov 11, 2016
* provider/azurerm: allow updating of lb_rule resource * check if rule is being updated rather than assuming created * added test to cover guard against multiple rules with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerRule_" -timeout 120m === RUN TestAccAzureRMLoadBalancerRule_basic --- PASS: TestAccAzureRMLoadBalancerRule_basic (157.45s) === RUN TestAccAzureRMLoadBalancerRule_removal --- PASS: TestAccAzureRMLoadBalancerRule_removal (163.67s) === RUN TestAccAzureRMLoadBalancerRule_inconsistentReads --- PASS: TestAccAzureRMLoadBalancerRule_inconsistentReads (150.00s) === RUN TestAccAzureRMLoadBalancerRule_update --- PASS: TestAccAzureRMLoadBalancerRule_update (164.20s) === RUN TestAccAzureRMLoadBalancerRule_duplicateRules --- PASS: TestAccAzureRMLoadBalancerRule_duplicateRules (137.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 772.846s * provider/azurerm: allow updating of lb_nat_rule resource * check if NAT rule is being updated rather than assuming created * added test to cover guard against multiple NAT rules with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerNatRule" -timeout 120m === RUN TestAccAzureRMLoadBalancerNatRule_basic --- PASS: TestAccAzureRMLoadBalancerNatRule_basic (148.48s) === RUN TestAccAzureRMLoadBalancerNatRule_removal --- PASS: TestAccAzureRMLoadBalancerNatRule_removal (163.48s) === RUN TestAccAzureRMLoadBalancerNatRule_update --- PASS: TestAccAzureRMLoadBalancerNatRule_update (176.97s) === RUN TestAccAzureRMLoadBalancerNatRule_duplicate --- PASS: TestAccAzureRMLoadBalancerNatRule_duplicate (136.36s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 625.301s * provider/azurerm: allow updating of lb_probe resource * check if probe is being updated rather than assuming created * added test to cover guard against multiple probes with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerProbe" -timeout 120m === RUN TestAccAzureRMLoadBalancerProbe_basic --- PASS: TestAccAzureRMLoadBalancerProbe_basic (134.53s) === RUN TestAccAzureRMLoadBalancerProbe_removal --- PASS: TestAccAzureRMLoadBalancerProbe_removal (168.06s) === RUN TestAccAzureRMLoadBalancerProbe_update --- PASS: TestAccAzureRMLoadBalancerProbe_update (175.99s) === RUN TestAccAzureRMLoadBalancerProbe_duplicate --- PASS: TestAccAzureRMLoadBalancerProbe_duplicate (139.01s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 617.598s * provider/azurerm: allow updating of lb_nat_pool resource * check if NAT pool is being updated rather than assuming created * added test to cover guard against multiple NAT pools with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerNatPool" -timeout 120m === RUN TestAccAzureRMLoadBalancerNatPool_basic --- PASS: TestAccAzureRMLoadBalancerNatPool_basic (146.52s) === RUN TestAccAzureRMLoadBalancerNatPool_removal --- PASS: TestAccAzureRMLoadBalancerNatPool_removal (158.34s) === RUN TestAccAzureRMLoadBalancerNatPool_update --- PASS: TestAccAzureRMLoadBalancerNatPool_update (174.05s) === RUN TestAccAzureRMLoadBalancerNatPool_duplicate --- PASS: TestAccAzureRMLoadBalancerNatPool_duplicate (136.94s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 615.866s
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
…rp#10016) * provider/azurerm: allow updating of lb_rule resource * check if rule is being updated rather than assuming created * added test to cover guard against multiple rules with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerRule_" -timeout 120m === RUN TestAccAzureRMLoadBalancerRule_basic --- PASS: TestAccAzureRMLoadBalancerRule_basic (157.45s) === RUN TestAccAzureRMLoadBalancerRule_removal --- PASS: TestAccAzureRMLoadBalancerRule_removal (163.67s) === RUN TestAccAzureRMLoadBalancerRule_inconsistentReads --- PASS: TestAccAzureRMLoadBalancerRule_inconsistentReads (150.00s) === RUN TestAccAzureRMLoadBalancerRule_update --- PASS: TestAccAzureRMLoadBalancerRule_update (164.20s) === RUN TestAccAzureRMLoadBalancerRule_duplicateRules --- PASS: TestAccAzureRMLoadBalancerRule_duplicateRules (137.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 772.846s * provider/azurerm: allow updating of lb_nat_rule resource * check if NAT rule is being updated rather than assuming created * added test to cover guard against multiple NAT rules with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerNatRule" -timeout 120m === RUN TestAccAzureRMLoadBalancerNatRule_basic --- PASS: TestAccAzureRMLoadBalancerNatRule_basic (148.48s) === RUN TestAccAzureRMLoadBalancerNatRule_removal --- PASS: TestAccAzureRMLoadBalancerNatRule_removal (163.48s) === RUN TestAccAzureRMLoadBalancerNatRule_update --- PASS: TestAccAzureRMLoadBalancerNatRule_update (176.97s) === RUN TestAccAzureRMLoadBalancerNatRule_duplicate --- PASS: TestAccAzureRMLoadBalancerNatRule_duplicate (136.36s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 625.301s * provider/azurerm: allow updating of lb_probe resource * check if probe is being updated rather than assuming created * added test to cover guard against multiple probes with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerProbe" -timeout 120m === RUN TestAccAzureRMLoadBalancerProbe_basic --- PASS: TestAccAzureRMLoadBalancerProbe_basic (134.53s) === RUN TestAccAzureRMLoadBalancerProbe_removal --- PASS: TestAccAzureRMLoadBalancerProbe_removal (168.06s) === RUN TestAccAzureRMLoadBalancerProbe_update --- PASS: TestAccAzureRMLoadBalancerProbe_update (175.99s) === RUN TestAccAzureRMLoadBalancerProbe_duplicate --- PASS: TestAccAzureRMLoadBalancerProbe_duplicate (139.01s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 617.598s * provider/azurerm: allow updating of lb_nat_pool resource * check if NAT pool is being updated rather than assuming created * added test to cover guard against multiple NAT pools with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerNatPool" -timeout 120m === RUN TestAccAzureRMLoadBalancerNatPool_basic --- PASS: TestAccAzureRMLoadBalancerNatPool_basic (146.52s) === RUN TestAccAzureRMLoadBalancerNatPool_removal --- PASS: TestAccAzureRMLoadBalancerNatPool_removal (158.34s) === RUN TestAccAzureRMLoadBalancerNatPool_update --- PASS: TestAccAzureRMLoadBalancerNatPool_update (174.05s) === RUN TestAccAzureRMLoadBalancerNatPool_duplicate --- PASS: TestAccAzureRMLoadBalancerNatPool_duplicate (136.94s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 615.866s
fatmcgav
pushed a commit
to fatmcgav/terraform
that referenced
this pull request
Feb 27, 2017
…rp#10016) * provider/azurerm: allow updating of lb_rule resource * check if rule is being updated rather than assuming created * added test to cover guard against multiple rules with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerRule_" -timeout 120m === RUN TestAccAzureRMLoadBalancerRule_basic --- PASS: TestAccAzureRMLoadBalancerRule_basic (157.45s) === RUN TestAccAzureRMLoadBalancerRule_removal --- PASS: TestAccAzureRMLoadBalancerRule_removal (163.67s) === RUN TestAccAzureRMLoadBalancerRule_inconsistentReads --- PASS: TestAccAzureRMLoadBalancerRule_inconsistentReads (150.00s) === RUN TestAccAzureRMLoadBalancerRule_update --- PASS: TestAccAzureRMLoadBalancerRule_update (164.20s) === RUN TestAccAzureRMLoadBalancerRule_duplicateRules --- PASS: TestAccAzureRMLoadBalancerRule_duplicateRules (137.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 772.846s * provider/azurerm: allow updating of lb_nat_rule resource * check if NAT rule is being updated rather than assuming created * added test to cover guard against multiple NAT rules with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerNatRule" -timeout 120m === RUN TestAccAzureRMLoadBalancerNatRule_basic --- PASS: TestAccAzureRMLoadBalancerNatRule_basic (148.48s) === RUN TestAccAzureRMLoadBalancerNatRule_removal --- PASS: TestAccAzureRMLoadBalancerNatRule_removal (163.48s) === RUN TestAccAzureRMLoadBalancerNatRule_update --- PASS: TestAccAzureRMLoadBalancerNatRule_update (176.97s) === RUN TestAccAzureRMLoadBalancerNatRule_duplicate --- PASS: TestAccAzureRMLoadBalancerNatRule_duplicate (136.36s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 625.301s * provider/azurerm: allow updating of lb_probe resource * check if probe is being updated rather than assuming created * added test to cover guard against multiple probes with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerProbe" -timeout 120m === RUN TestAccAzureRMLoadBalancerProbe_basic --- PASS: TestAccAzureRMLoadBalancerProbe_basic (134.53s) === RUN TestAccAzureRMLoadBalancerProbe_removal --- PASS: TestAccAzureRMLoadBalancerProbe_removal (168.06s) === RUN TestAccAzureRMLoadBalancerProbe_update --- PASS: TestAccAzureRMLoadBalancerProbe_update (175.99s) === RUN TestAccAzureRMLoadBalancerProbe_duplicate --- PASS: TestAccAzureRMLoadBalancerProbe_duplicate (139.01s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 617.598s * provider/azurerm: allow updating of lb_nat_pool resource * check if NAT pool is being updated rather than assuming created * added test to cover guard against multiple NAT pools with the same name TF_ACC=1 go test ./builtin/providers/azurerm -v -run "TestAccAzureRMLoadBalancerNatPool" -timeout 120m === RUN TestAccAzureRMLoadBalancerNatPool_basic --- PASS: TestAccAzureRMLoadBalancerNatPool_basic (146.52s) === RUN TestAccAzureRMLoadBalancerNatPool_removal --- PASS: TestAccAzureRMLoadBalancerNatPool_removal (158.34s) === RUN TestAccAzureRMLoadBalancerNatPool_update --- PASS: TestAccAzureRMLoadBalancerNatPool_update (174.05s) === RUN TestAccAzureRMLoadBalancerNatPool_duplicate --- PASS: TestAccAzureRMLoadBalancerNatPool_duplicate (136.94s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 615.866s
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.