Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add aws_alb_listener data source #10181

Merged

Conversation

vancluever
Copy link
Contributor

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
#10180 is merged.

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
hashicorp#10180 is merged.
@vancluever
Copy link
Contributor Author

Just realized I forgot about docs! Will add these ASAP.

@vancluever vancluever changed the title provider/aws: Add aws_alb_listener data source [WIP] provider/aws: Add aws_alb_listener data source Nov 17, 2016
@vancluever vancluever changed the title [WIP] provider/aws: Add aws_alb_listener data source provider/aws: Add aws_alb_listener data source Nov 17, 2016
@vancluever
Copy link
Contributor Author

All docs added, this one is good to go!

@stack72
Copy link
Contributor

stack72 commented Nov 18, 2016

LGTM! Thanks so much for the follow up commit for the docs - the tests are green too :) Bonus points for the use of errwrap ;)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccDataSourceAWSALBListener_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/18 12:55:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccDataSourceAWSALBListener_ -timeout 120m
=== RUN   TestAccDataSourceAWSALBListener_basic
--- PASS: TestAccDataSourceAWSALBListener_basic (145.73s)
=== RUN   TestAccDataSourceAWSALBListener_https
--- PASS: TestAccDataSourceAWSALBListener_https (122.15s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    267.902s

@stack72 stack72 merged commit 3ac05a5 into hashicorp:master Nov 18, 2016
stack72 pushed a commit that referenced this pull request Nov 18, 2016
* provider/aws: Add aws_alb_listener data source

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
#10180 is merged.

* provider/aws: Add aws_alb_listener data source docs

Now documented.
@vancluever
Copy link
Contributor Author

Thank you sir!

gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
* provider/aws: Add aws_alb_listener data source

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
hashicorp#10180 is merged.

* provider/aws: Add aws_alb_listener data source docs

Now documented.
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Feb 27, 2017
* provider/aws: Add aws_alb_listener data source

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
hashicorp#10180 is merged.

* provider/aws: Add aws_alb_listener data source docs

Now documented.
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants