Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_prefix_list data source - Add ability to select PL by name #10248

Merged
merged 1 commit into from
Nov 20, 2016
Merged

aws_prefix_list data source - Add ability to select PL by name #10248

merged 1 commit into from
Nov 20, 2016

Conversation

ewbankkit
Copy link
Contributor

Add the ability to select a prefix list by name instead of/as well as by name.
I decided not to call the attribute prefix_list_name as we already have a name attribute, which I reused.
I wish I had done the same with the id attribute when I added this data source but I know now 😄.
Updated the documentation and acceptance tests:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccDataSourceAwsPrefixList'

@stack72
Copy link
Contributor

stack72 commented Nov 20, 2016

Hi @ewbankkit

Thanks for the work here - this is a good addition :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccDataSourceAwsPrefixList'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/20 16:20:42 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccDataSourceAwsPrefixList -timeout 120m
=== RUN   TestAccDataSourceAwsPrefixList
--- PASS: TestAccDataSourceAwsPrefixList (16.98s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    17.005s

@stack72 stack72 merged commit 3255921 into hashicorp:master Nov 20, 2016
@ewbankkit ewbankkit deleted the aws-pl-data-source-find-by-name branch November 20, 2016 21:04
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Feb 27, 2017
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants