Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: create common schema for location field, add diff suppress #10409

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

pmcatominey
Copy link
Contributor

As suggested in #9208.

Touches a lot of resources though the diff is pretty small, can be broken up into smaller commits/PRs is preferred.

Ran the following tests which are passing (no output from TeamCity runner)

go test -c ./builtin/providers/azurerm -o ./builtin/providers/azurerm/test-azurerm
TestAccAzureRMClientConfig_basic
TestAccAzureRMAvailabilitySet_basic
TestAccAzureRMDnsAAAARecord_basic
TestAccAzureRMDnsARecord_basic
TestAccAzureRMCdnProfile_basic
TestAccAzureRMDnsCNameRecord_basic
TestAccAzureRMCdnEndpoint_basic
TestAccAzureRMDnsMxRecord_basic
TestAccAzureRMDnsNsRecord_basic
TestAccAzureRMDnsSrvRecord_basic
TestAccAzureRMDnsTxtRecord_basic
TestAccAzureRMDnsZone_basic
TestAccAzureRMKeyVault_basic
TestAccAzureRMLoadBalancerBackEndAddressPool_basic
TestAccAzureRMLoadBalancerNatPool_basic
TestAccAzureRMEventHubNamespace_basic
TestAccAzureRMLoadBalancerNatRule_basic
TestAccAzureRMEventHub_basic
TestAccAzureRMLoadBalancerProbe_basic
TestAccAzureRMLoadBalancer_basic
TestAccAzureRMLoadBalancerRule_basic
TestAccAzureRMLocalNetworkGateway_basic
TestAccAzureRMNetworkSecurityGroup_basic
TestAccAzureRMPublicIpStatic_basic
TestAccAzureRMNetworkInterface_basic
TestAccAzureRMNetworkSecurityRule_basic
TestAccAzureRMResourceGroup_basic
TestAccAzureRMPublicIpDynamic_basic
TestAccAzureRMRouteTable_basic
TestAccAzureRMSearchService_basic
TestAccAzureRMRoute_basic
TestAccAzureRMSqlDatabase_basic
TestAccAzureRMServiceBusNamespace_basic
TestAccAzureRMServiceBusSubscription_basic
TestAccAzureRMServiceBusTopic_basic
TestAccAzureRMSqlServer_basic
TestAccAzureRMSqlFirewallRule_basic
TestAccAzureRMStorageBlob_basic
TestAccAzureRMStorageAccount_basic
TestAccAzureRMStorageContainer_basic
TestAccAzureRMStorageQueue_basic
TestAccAzureRMStorageShare_basic
TestAccAzureRMStorageTable_basic
TestAccAzureRMSubnet_basic
TestAccAzureRMTrafficManagerEndpoint_basic
TestAccAzureRMVirtualNetwork_basic
TestAccAzureRMVirtualNetworkPeering_basic
TestAccAzureRMTemplateDeployment_basic
TestAccAzureRMVirtualMachineExtension_basic

@stack72
Copy link
Contributor

stack72 commented Nov 29, 2016

LGTM! Thanks for the work here @pmcatominey :)

@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants