Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Add Lightsail Instance #10473

Merged
merged 1 commit into from
Dec 5, 2016
Merged

provider/aws: Add Lightsail Instance #10473

merged 1 commit into from
Dec 5, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Dec 1, 2016 •
edited
Loading

Support for AWS Lightsail

Includes:

  • Docs for aws_lightsail_instance
  • Tests for aws_lightsail_instance
  • aws_lightsail_instance resource

@catsby
Copy link
Contributor Author

catsby commented Dec 1, 2016

We're limited on key_pair right now, we'll need a separate resource for that

@catsby catsby changed the title [WIP] provider/aws: Add Lightsail Instance provider/aws: Add Lightsail Instance Dec 2, 2016
stack72
stack72 reviewed Dec 2, 2016
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catsby

Overall this looks pretty spot on - i left 2 small things inline.

1 other thing, is it worth adding a few more tests? This would allow us to check for the _disappears, import and maybe an update

Thoughts?

P.

builtin/providers/aws/resource_aws_lightsail_instance.go
req.KeyPairName = aws.String(v.(string))
}
// // encoding required?
// if v, ok := d.GetOk("user_data"); ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intentionally missing? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp :)

builtin/providers/aws/resource_aws_lightsail_instance.go
log.Printf("[ERR] Error waiting for instance (%s) to become ready: %s", d.Id(), err)
}

// return resourceAwsLightsailInstanceUpdate(d, meta)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth removing this old comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops :)

@catsby
Copy link
Contributor Author

catsby commented Dec 2, 2016

@stack72 thanks for the review, I've updated it!

1 other thing, is it worth adding a few more tests? This would allow us to check for the _disappears

I added TestAccAWSLightsailInstance_disapear for this

import

The _basic test has the IDRefreshName thing, any more than that?

maybe an update

Sadly everything is ForceNew at the moment, the API doesn't offer much for updates at all. The resource lacks an Update method

@catsby
provider/aws: Add Lightsail Instance
44ffe71 
Adds initial support for AWS Lightsail Instances
@stack72
Copy link
Contributor

stack72 commented Dec 4, 2016

LGTM! thanks for the changes :)

@catsby catsby merged commit e477658 into master Dec 5, 2016
@catsby catsby deleted the f-aws-lightsail-instance branch December 5, 2016 14:39
@jessefulton jessefulton mentioned this pull request Dec 6, 2016
Closed
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stack72 stack72 stack72 left review comments

Assignees
No one assigned
Labels
provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catsby @stack72