-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS CA Central 1 Region #10618
Conversation
Hey @eddywashere thanks! Is there any more info on this new region that we can use in our other files that relate to regions? See #9429 as an example |
Thanks for this, @eddywashere. There are a few other things we need to set to get full support for a new region (lookup tables for service ids that differ in each region, as discussed in #10470) but this is a good start. It looks like there is some debate in #10470 about whether to enable the region before all of the relevant metadata has been updated. Presumably whatever decision is made there will apply here too, so I'm mainly just posting this comment to create the connection between the two issues. |
Added additional metadata. This uses the new region syntax for s3 website endpoints, so no change needed there. Is there a full list of potential data to add or is the info in #9249 sufficient? If it is, then I'm just waiting on elb info to be published. |
edf0565
to
75f8524
Compare
Here's the missing ALB/ELB account ID: Even though it's not published anywhere yet, you can go ahead and enable logging for ALB/ELB in the AWS Console and let the console create the S3 bucket - which includes creation of the policy. The policy then contains the relevant account ID. 😉 |
Thanks @radeksimko. Just verified and added it. |
Thanks for the fast turnaround here @eddywashere :) Paul |
Will this make it into 0.8 release? Support for this region is a critical issue for us. |
it certainly will @darrin-wortlehock - it's already in master :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
New region
ca-central-1
, and blog post.Closes #10617