Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for name_prefix to google_compute_ssl_certificate #10684

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Add support for name_prefix to google_compute_ssl_certificate #10684

merged 1 commit into from
Dec 13, 2016

Conversation

cblecker
Copy link
Contributor

@cblecker cblecker commented Dec 12, 2016

Fixes #10546.

Haven't made docs yet, but wanted to get code up for review. Adds name_prefix option, reusing code from https://github.com/hashicorp/terraform/blob/master/builtin/providers/google/resource_compute_instance_template.go.

(cc: @paddyforan)

@paddycarver
Copy link
Contributor

Thanks for jumping on this @cblecker! This looks great. I love that name and name_prefix are both optional now; the only things that it would be cool to add is just a quick test case that exercises a code path where the config specifies neither name nor name_prefix, and a documentation update specifying the new attribute and reflecting that both are now optional.

@cblecker
Copy link
Contributor Author

@paddyforan --
Done! Ready for another look :)

@paddycarver
Copy link
Contributor

LGTM. 👍 Thanks for tackling this, appreciated.

@paddycarver paddycarver merged commit a08d562 into hashicorp:master Dec 13, 2016
@cblecker cblecker deleted the gcp-ssl-cert-name-prefix branch December 13, 2016 00:43
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a google_compute_ssl_certificate fails if it is used by a google_compute_target_https_proxy
2 participants