Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Improved the SNS topic subscription protocols validation #10704

Merged
merged 1 commit into from
Dec 13, 2016

Conversation

Ninir
Copy link
Contributor

@Ninir Ninir commented Dec 13, 2016

Reasonning for this change

Partially fixes #10697

Acceptance tests

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSNSTopicSubscription_basic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/13 17:53:20 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSNSTopicSubscription_basic -timeout 120m
=== RUN   TestAccAWSSNSTopicSubscription_basic
--- PASS: TestAccAWSSNSTopicSubscription_basic (22.24s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	22.278s

@catsby
Copy link
Contributor

catsby commented Dec 13, 2016

Thank you @Ninir !

@catsby catsby merged commit 56b0e87 into hashicorp:master Dec 13, 2016
@Ninir Ninir deleted the r-aws-sns_topic-protocols branch March 20, 2017 18:14
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sns topic subscription re-creating
2 participants