provider/vault: Remove user input for optional vault provider fields #11082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mongey
changed the title
|
Adding a |
|
It seems that the Vault Client allows |
Mongey
changed the title
Mongey
changed the title
|
+1 , thanks @Mongey |
|
LGTM! thanks for the work here :) |
toddnni
added a commit
to toddnni/terraform-provider-shell
that referenced
this pull request
Jul 11, 2017
Tested with v0.9.11. Fixed in hashicorp/terraform#11082
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again @apparentlymart 👋
When
ca_cert_dirandca_cert_fileare not set in thevaultprovider, Terraform will prompt the user for input.Looking at
helper/schema/schema.goit seems that a nilDefaultValuefor aTypeStringwill ask the user for input. Defaulting to""will allow us to continue without user input.It also seems like Terraform isn't handling
TypeList, causing the crash described in #10505.