providers/google: Add subnetwork_project field to enable cross-project networking in instance templates

[zbikmarc]

This change allows to use XPN feature with instance templates. It is an extension of #9662

One thing which is currently missing is showing subnetwork project in terraform show.

[zbikmarc]

I do not know how to pass GOOGLE_XPN_HOST_PROJECT to travis.

[stack72]

If you omit this check, then the travis build will pass - we have this already setup with the correct parameter

[stack72]

Hi @zbikmarc

Thanks for the work here - I made a comment inline to remove the check for the XPN project - we have that handled in the provider tests

That will make the build pass

Paul

[stack72]

Hi @zbikmarc

make fmt will now fix the build in this case

P.

[zbikmarc]

I hope this time everything will be ok ;)

[stack72]

Hi @zbikmarc

thanks for the work here so far, unfortunately, the test doesn't pass:

=== RUN   TestAccComputeInstanceTemplate_subnet_xpn
--- FAIL: TestAccComputeInstanceTemplate_subnet_xpn (77.45s)
	testing.go:265: Step 0 error: After applying this step, the plan was not empty:

		DIFF:

		DESTROY/CREATE: google_compute_instance_template.foobar
		  automatic_restart:                      "true" => "true"
		  can_ip_forward:                         "false" => "false"
		  disk.#:                                 "1" => "1"
		  disk.0.auto_delete:                     "true" => "true"
		  disk.0.boot:                            "true" => "true"
		  disk.0.disk_size_gb:                    "10" => "10"
		  disk.0.disk_type:                       "pd-standard" => "<computed>"
		  disk.0.interface:                       "SCSI" => "<computed>"
		  disk.0.mode:                            "READ_WRITE" => "<computed>"
		  disk.0.source_image:                    "debian-8-jessie-v20160803" => "debian-8-jessie-v20160803"
		  disk.0.type:                            "PERSISTENT" => "<computed>"
		  machine_type:                           "n1-standard-1" => "n1-standard-1"
		  metadata.%:                             "1" => "1"
		  metadata.foo:                           "bar" => "bar"
		  metadata_fingerprint:                   "EEf91SmZULE=" => "<computed>"
		  name:                                   "instance-test-4y3k6d04n8" => "instance-test-4y3k6d04n8"
		  network_interface.#:                    "1" => "1"
		  network_interface.0.network:            "network-y9dm32zelq" => "<computed>"
		  network_interface.0.subnetwork:         "subnetwork-2hhijid3f1" => "subnetwork-2hhijid3f1"
		  network_interface.0.subnetwork_project: "" => "xpn-hc-terraform-testing" (forces new resource)
		  project:                                "hc-terraform-testing" => "<computed>"
		  region:                                 "us-central1" => "us-central1"
		  scheduling.#:                           "1" => "<computed>"
		  self_link:                              "https://www.googleapis.com/compute/v1/projects/hc-terraform-testing/global/instanceTemplates/instance-test-4y3k6d04n8" => "<computed>"
		  tags_fingerprint:                       "" => "<computed>"

I believe this is because you are not setting the subnetwork_project id in the Read func - I am not 100% sure this is the case, but though i'd make a suggestions

Thanks

Paul

[zbikmarc]

I added subnetwork_project to Read.
I tried to run tests locally but my google cloud account is too limited to perform those tests.

[zbikmarc]

@stack72
Are tests passing now?

[stack72]

Nice work @zbikmarc :)

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeInstanceTemplate_subnet_xpn'                    ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/12 16:02:01 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeInstanceTemplate_subnet_xpn -timeout 120m
=== RUN   TestAccComputeInstanceTemplate_subnet_xpn
--- PASS: TestAccComputeInstanceTemplate_subnet_xpn (114.06s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	114.076s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.