Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for setting MSSQL Timezone in aws_db_instance #11247

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jan 17, 2017

Adds support for setting the Timezone for MSSQL databases in the aws_db_instance resource. Fixes #8937

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBInstance_MSSQL_TZ -timeout 120m
=== RUN   TestAccAWSDBInstance_MSSQL_TZ
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (2045.61s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    2045.692s

@stack72
Copy link
Contributor

stack72 commented Jan 18, 2017

LGTM! Thanks @catsby :)

@catsby catsby merged commit c5f899d into master Jan 18, 2017
@catsby catsby deleted the b-aws-rds-mssql-timezone branch January 18, 2017 14:39
@bmurtagh
Copy link

Awesome! Ty @catsby!

@riverofcode
Copy link

I just got a release of 0.8.5 and set the "timezone" for a SQL Server SE deployment to "Eastern Standard Time" as such timezone = "Eastern Standard Time" in my tf code but it didn't set the instance.

@catsby
Copy link
Contributor Author

catsby commented Jan 27, 2017

Hey @riverofcode – can you expand on that some? Did you set the timezone before creating the instance? It's only settable on create, so setting it after should force a destroy and recreate scenario in the next plan.

When you say "didn't set the instance", could you possibly provide an example config that shows this? Here's a config I used this morning to create 3 DBs, demonstrating the timezones. Each created a DB in the timezone I expected (2 are the same, but one is "US Eastern" and the other just "Eastern", for the same results:

@catsby catsby added the waiting-response An issue/pull request is waiting for a response from the community label Jan 27, 2017
@riverofcode
Copy link

Stupidity on my part. Problem resolved. :-(

@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: RDS MSSQL Time Zone Support
4 participants