-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destroy Provisioners #11329
Destroy Provisioners #11329
Conversation
destroy provisioners.
90eeef4
to
2055885
Compare
during updating or any other lifecycle. They are meant as a means to perform | ||
bootstrapping of a system. | ||
|
||
If a creation-time provisioner fails, the resource is marked as **tainted**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea, but we should probably document it as a backwards compatibility change since buggy scripts that didn't exit cleanly would have been OK previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How so? This behavior is the same as always.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, maybe I'm mis-remembering. I was thinking a failed provisioner didn't mark the resource as tainted, and left it as-is in the state. No problem then, if nothing changed.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #386
I'm going to go light on the details in this PR description since there is a really good discussion and RFC in #386. You can also view the website changes in this PR to see how it works!
Highlights:
on_failure
to determine behavior when a provisioner fails (works for both create and destroy provisioners)