add Aurora create cross region read replica cluster function

[arcadiatea]

Add feature for Aurora cross region read replica cluster function. replication_source_identifier be added and tested with ticketmaster test code.
I cannot provide test code updated for this feature in ../builtin/providers/aws/resource_aws_rds_cluster_test.go.
Couple reasons
a. aws_rds_cluster not return cluster arn, neither aws rds create-db-cluster. replication_source_identifier field requires cluster arn.
b. replication_source_identifier requires remote region. the function is not available for single region
c. a read replica cluster cannot be destroy, it needs to be promoted to independent cluster because destroy. The promote command probably not in terraform scope.

Create a read replica cluster took 90 minutes, because so the timeout of rds cluster be modified from 40 minutes to 120 minutes

[arcadiatea]

Any words on this one? We need this for our production DR solution.

[arcadiatea]

This is fix for #11401.

[stack72]

Hi @arcadiatea

Thanks for this work - this is looking great. Please can you tell me how I can test this to make sure it works as expected?

Thanks

Paul

[arcadiatea]

Hi. Paul, I can paste the test code here.
The test step is,
a. I build an aruroa cluster on us-east-1 region under ticketmaster's account
b. I update the terraform test code to for testing this feature
c. observation: the test code will build read replicate successfully but when error out during destroy part because AWS not allow destroy a read replica aurora

~/builtin/providers/aws/resource_aws_rds_cluster_test.go

func TestAccAWSCluster_replication(t *testing.T) {
var v rds.DBCluster

resource.Test(t, resource.TestCase{
	PreCheck:     func() { testAccPreCheck(t) },
	Providers:    testAccProviders,
	CheckDestroy: testAccCheckAWSClusterDestroy,
	Steps: []resource.TestStep{
		{
			Config: testAccAWSCluster_replication(acctest.RandInt()),
			Check: resource.ComposeTestCheckFunc(
				testAccCheckAWSClusterExists("aws_rds_cluster.default", &v),
			),
		},
	},
})

}

func testAccAWSCluster_replication(n int) string {
return fmt.Sprintf(`

resource "aws_rds_cluster" "default" {
cluster_identifier = "tf-aurora-readcluster-%d"
availability_zones = ["us-west-2a","us-west-2b","us-west-2c"]
db_cluster_parameter_group_name = "default.aurora5.6"
replication_source_identifier = "arn:aws:rds:us-east-1:<account_number>:cluster: "
db_subnet_group_name = "db.sandbox"
tags {
Environment = "production"
}
}

resource "aws_rds_cluster_instance" "replica_instances" {
identifier = "tf-cluster-instance-r-%d"
cluster_identifier = "${aws_rds_cluster.default.id}"
instance_class = "db.t2.medium"
db_parameter_group_name = "default.aurora5.6"
}
`, n, n)
}

[stack72]

Hi @arcadiatea

I am satisfied that this can't be tested in an automated fashion. I have checked the functionality that it doesn't break the existing path so this is GTG :)

Thanks for the work here

Paul

[brijeshsp]

Hi @stack72

Unable to deploy RDS cross-region read replica:
$ terraform version
Terraform v0.8.7

Error in terraform plan:

• aws_rds_cluster.default: : invalid or unknown key: replication_source_identifier

But I see that in the changelog of 0.8.6, https://github.com/hashicorp/terraform/blob/master/CHANGELOG.md#086-07-february-2017
the change is available whereas the terraform binary doesn't show up the same.

Terraform code:

provider "aws" {
region = "us-west-2"
}

resource "aws_rds_cluster" "default" {
cluster_identifier = "tf-aurora-readcluster-1"
availability_zones = ["us-west-2a","us-west-2b","us-west-2c"]
db_cluster_parameter_group_name = "default.aurora5.6"
replication_source_identifier = "arn:aws:rds:us-east-1:<account_id>4:cluster:-cluster"
db_subnet_group_name = "default"
}

resource "aws_rds_cluster_instance" "replica_instances" {
identifier = "tf-cluster-instance-r-1"
cluster_identifier = "${aws_rds_cluster.default.id}"
instance_class = "db.t2.medium"
db_parameter_group_name = "default.aurora5.6"
}

[arcadiatea]

I saw the code in master branch but not in 0.8.6, 0.8.7 or 0.8.8

[solled]

@stack72 Is there a plan for this to be available in the next version, and when that will be? We need it for our DR plan. Thank you.

[arcadiatea]

@stack72 which version will include this feature? I saw the code is in master branch.

[jgruhl]

@stack72 any update here?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.