Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Heroku provisioner (of sorts) #116

Closed
catsby opened this issue Jul 30, 2014 · 3 comments
Closed

Idea: Heroku provisioner (of sorts) #116

catsby opened this issue Jul 30, 2014 · 3 comments
Labels

Comments

@catsby
Copy link
Contributor

catsby commented Jul 30, 2014

I love the Heroku integration (I'm biased), however I felt there's a piece missing.

Heroku has a Build API (docs here and more here).

TL;DR; you can provide a source_ball URL (which can be a GitHub URL) and Heroku will compile and deploy it to the app specified.

I love that Terraform can setup the configs and add-ons, but I think an initial provision of the app with source code if available would be awesome. I imagine this as a provisioner, and only ran on initial setup, with end users using normal git push or other deploy methods for future updates, so as not to confuse this with using terraform apply for source deployments.

A caveat would be build output... similar to #70 , you'd likely want to know the output as this is happening.

This may take some tweaking to bgentry/heroku-go , but I believe that client is generated, so maybe not...

A Heroku provisioner doesn't quite fit in with file, local-exec or remote-exec, and is kind of a special case... maybe that's undesirable.

Thoughts?

@catsby
Copy link
Contributor Author

catsby commented Jul 30, 2014

Another caveat could be that you probably want to deploy the code last, so that all configs and add-ons are present ¯_(ツ)_/¯

@pearkes
Copy link
Contributor

pearkes commented Jul 30, 2014

Hey @catsby!

I think this is a pretty cool idea. However, it's a little out-of-scope for Terraform right now. Deployment is something we don't really touch.

However, getting an initial repo linked up and sent to the Heroku app is something that Terraform might do. Or, if part of your infrastructure is a Heroku app that is simply a service deployed from some source, and less of an application, Terraform also wants to support that.

All that being said, we're focusing on getting stuff like AWS up to snuff pretty intently right now. But if you are interested in contributing this, I'd love to look at it! Going to close this one for now, feel free to ask further questions if you need help.

@catsby
Copy link
Contributor Author

catsby commented Jul 30, 2014

Deployment is something we don't really touch...However, getting an initial repo linked up and sent to the Heroku app is something that Terraform might do.

Agreed, I meant to emphasize provisioner there, we'd only want to do this on first run.

@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants