Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest updates to aws_ssm_document resource. #11671

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

liamjbennett
Copy link
Contributor

@liamjbennett liamjbennett commented Feb 3, 2017

A parameter document_type and a few more attributes returned based
upon the new API.

  • new parameters
  • new attributes
  • validation
  • acceptance tests
  • docs update

@liamjbennett liamjbennett force-pushed the ssm_document_update branch 2 times, most recently from cea3996 to c3d9d56 Compare February 3, 2017 17:14
@liamjbennett liamjbennett force-pushed the ssm_document_update branch 2 times, most recently from d5688fa to 1ff76a3 Compare February 7, 2017 10:21
@liamjbennett liamjbennett changed the title [WIP] Latest updates to aws_ssm_document resource. Latest updates to aws_ssm_document resource. Feb 7, 2017
A parameter `document_type` and a few more attributes returned based
upon the new API.
@stack72
Copy link
Contributor

stack72 commented Feb 8, 2017

LGTM! Thanks for fixing the test case we spoke about on slack

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSM'                                            ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/08 12:34:53 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSM -timeout 120m
=== RUN   TestAccAWSSSMActivation_basic
--- PASS: TestAccAWSSSMActivation_basic (30.62s)
=== RUN   TestAccAWSSSMAssociation_basic
--- PASS: TestAccAWSSSMAssociation_basic (128.79s)
=== RUN   TestAccAWSSSMDocument_basic
--- PASS: TestAccAWSSSMDocument_basic (22.15s)
=== RUN   TestAccAWSSSMDocument_permission
--- PASS: TestAccAWSSSMDocument_permission (24.08s)
=== RUN   TestAccAWSSSMDocument_params
--- PASS: TestAccAWSSSMDocument_params (25.11s)
=== RUN   TestAccAWSSSMDocument_automation
--- PASS: TestAccAWSSSMDocument_automation (52.64s)
=== RUN   TestAccAWSSSMDocument_documentTypeValidation
--- PASS: TestAccAWSSSMDocument_documentTypeValidation (0.00s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	283.415s

@stack72 stack72 merged commit d760f21 into hashicorp:master Feb 8, 2017
stack72 pushed a commit that referenced this pull request Feb 8, 2017
A parameter `document_type` and a few more attributes returned based
upon the new API.
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants