Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: New DataSource: aws_partition #11675

Merged
merged 1 commit into from
Feb 4, 2017

Conversation

ValFadeev
Copy link
Contributor

Hello, my first PR here.

This data source allows AWS partition too be looked up when constructing resource ARN's, for example, in IAM policy documents. One less variable to keep track of when writing manifests to be reused in different partitions, e.g. aws/aws-cn. Inspiration taken from aws_caller_identity.

data "aws_partition" "current" { }

data "aws_iam_policy_document" "s3_policy" {
  statement {
    sid = "1"

    actions = [
      "s3:ListBucket",
    ]

    resources = [
      "arn:${data.aws_partition.current.partition}:s3:::my-bucket",
    ]
  }
}

resource "aws_iam_policy" "s3_policy" {
  name   = "my-policy"
  path   = "/"
  policy = "${data.aws_iam_policy_document.s3_policy.json}"
}
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSPartition_basic -timeout 120m
=== RUN   TestAccAWSPartition_basic
--- PASS: TestAccAWSPartition_basic (10.81s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	10.837s

@stack72
Copy link
Contributor

stack72 commented Feb 4, 2017

This is a fantastic data source! Nice work :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSPartition_basic'                                                        ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/04 12:52:43 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSPartition_basic -timeout 120m
=== RUN   TestAccAWSPartition_basic
--- PASS: TestAccAWSPartition_basic (52.19s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	52.212s

@stack72 stack72 merged commit cb8d85f into hashicorp:master Feb 4, 2017
arcadiatea pushed a commit to ticketmaster/terraform that referenced this pull request Feb 9, 2017
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants