provider/ignition: migration from resources to data resources

[mcuadros]

Fixes: #11518

[stack72]

Hi @mcuadros

Thanks for the work here - I understand why we need to do this. Right now, this is backwards incompatible - which means we would need to duplicate the resources and deprecate the old ones etc

Luckily, the awesome @apparentlymart, wrote a shim function that he has used to map resources to data_sources

You can see an example of it here
and here

This would then allow us to keep backwards compatibility with older versions :)

Thoughts?

Paul

[mcuadros]

@stack72 done

[mcuadros]

@stack72 ping

[mildred]

Is this a merge that failed?

[mildred]

merge conflict?

[mcuadros]

@mildred nice catch! solved

[pgray]

Pulled down this branch and started working with it.
Great work!

Any idea on amount of time left to review?

[mildred]

By the way, we are using this in production and it works well.

[alexsomesan]

👍 I would also like to see this merged. It's a biting us a little bit, using the latest stable release.

[stack72]

LGTM! Thanks for the work here - sorry it took so long

% make testacc TEST=./builtin/providers/ignition                                                                                            ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/06 14:21:46 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/ignition -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestValidateUnit
--- PASS: TestValidateUnit (0.00s)
=== RUN   TestIngnitionFileReplace
--- PASS: TestIngnitionFileReplace (0.05s)
=== RUN   TestIngnitionFileAppend
--- PASS: TestIngnitionFileAppend (0.04s)
=== RUN   TestIngnitionDisk
--- PASS: TestIngnitionDisk (0.07s)
=== RUN   TestIngnitionDiskResource
--- PASS: TestIngnitionDiskResource (0.30s)
=== RUN   TestIngnitionFile
--- PASS: TestIngnitionFile (0.06s)
=== RUN   TestIngnitionFilesystem
--- PASS: TestIngnitionFilesystem (0.07s)
=== RUN   TestIngnitionGroup
--- PASS: TestIngnitionGroup (0.04s)
=== RUN   TestIngnitionNetworkdUnit
--- PASS: TestIngnitionNetworkdUnit (0.03s)
=== RUN   TestIngnitionRaid
--- PASS: TestIngnitionRaid (0.04s)
=== RUN   TestIngnitionSystemdUnit
--- PASS: TestIngnitionSystemdUnit (0.03s)
=== RUN   TestIngnitionSystemdUnitEmptyContentWithDropIn
--- PASS: TestIngnitionSystemdUnitEmptyContentWithDropIn (0.03s)
=== RUN   TestIgnitionSystemdUnit_emptyContent
--- PASS: TestIgnitionSystemdUnit_emptyContent (0.03s)
=== RUN   TestIngnitionUser
--- PASS: TestIngnitionUser (0.03s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/ignition	0.851s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.