provider/azurerm: Add support for extensions on virtual machine scale sets #12124
Conversation
|
@stack72 Any issues with this PR or further items to address? |
rrudduck
force-pushed
the
vmss_extensions
branch
from
8e01879
to
0ca483f
Compare
rrudduck
changed the title
There was a problem hiding this comment.
Hey @rrudduck
I've left a couple of small comments, otherwise looks good!
| if properties.Settings != nil { | ||
| settings, err := flattenArmVirtualMachineExtensionSettings(*properties.Settings) | ||
| if err == nil { | ||
| e["settings"] = settings |
There was a problem hiding this comment.
Would prefer the err was returned here
| @@ -783,6 +876,13 @@ func resourceArmVirtualMachineScaleSetOsProfileLWindowsConfigHash(v interface{}) | |||
| return hashcode.String(buf.String()) | |||
| } | |||
|
|
|||
| func resourceArmVirtualMachineScaleSetExtensionHash(v interface{}) int { | |||
There was a problem hiding this comment.
This function should write all the fields for the extension to ensure the diff works properly.
There was a problem hiding this comment.
Done with the exception of the settings and protected_settings fields since they use the alternate diff funcs.
|
@pmcatominey Updates done. Let me know if you see anything else. |
… sets (#12124) * Add support for vmss extensions. * Update website. * Add multi extension test. * Return error from settings parsing. * Update extension hash.
… sets (hashicorp#12124) * Add support for vmss extensions. * Update website. * Add multi extension test. * Return error from settings parsing. * Update extension hash.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This PR adds support for adding one or more extensions to virtual machine scale sets.