Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/pagerduty: Setting incident_urgency_rule as optional #12211

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

heimweh
Copy link
Contributor

@heimweh heimweh commented Feb 23, 2017

This PR sets the incident_urgency_rule to Optional which is currently set as Required but according to the resource documentation and the PagerDuty API reference it's an optional.

This should resolve #12149

@heimweh heimweh changed the title [WIP] provider/pagerduty: Setting incident_urgency_rule as optional provider/pagerduty: Setting incident_urgency_rule as optional Feb 23, 2017
@stack72
Copy link
Contributor

stack72 commented Feb 23, 2017

LGTM

% make testacc TEST=./builtin/providers/pagerduty                                                                                          ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/23 21:28:45 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/pagerduty -v  -timeout 120m
=== RUN   TestAccDataSourcePagerDutyEscalationPolicy_Basic
--- PASS: TestAccDataSourcePagerDutyEscalationPolicy_Basic (8.67s)
=== RUN   TestAccDataSourcePagerDutySchedule_Basic
--- PASS: TestAccDataSourcePagerDutySchedule_Basic (9.30s)
=== RUN   TestAccDataSourcePagerDutyUser_Basic
--- PASS: TestAccDataSourcePagerDutyUser_Basic (4.23s)
=== RUN   TestAccPagerDutyVendor_Basic
--- PASS: TestAccPagerDutyVendor_Basic (10.22s)
=== RUN   TestAccPagerDutyEscalationPolicy_import
--- PASS: TestAccPagerDutyEscalationPolicy_import (6.40s)
=== RUN   TestAccPagerDutySchedule_import
--- PASS: TestAccPagerDutySchedule_import (8.90s)
=== RUN   TestAccPagerDutyServiceIntegration_import
--- PASS: TestAccPagerDutyServiceIntegration_import (17.18s)
=== RUN   TestAccPagerDutyService_import
--- PASS: TestAccPagerDutyService_import (11.23s)
=== RUN   TestAccPagerDutyServiceWithIncidentUrgency_import
--- PASS: TestAccPagerDutyServiceWithIncidentUrgency_import (10.25s)
=== RUN   TestAccPagerDutyTeam_import
--- PASS: TestAccPagerDutyTeam_import (3.32s)
=== RUN   TestAccPagerDutyUser_import
--- PASS: TestAccPagerDutyUser_import (4.01s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProviderImpl
--- PASS: TestProviderImpl (0.00s)
=== RUN   TestAccPagerDutyAddon_Basic
--- PASS: TestAccPagerDutyAddon_Basic (4.27s)
=== RUN   TestAccPagerDutyEscalationPolicy_Basic
--- PASS: TestAccPagerDutyEscalationPolicy_Basic (9.77s)
=== RUN   TestAccPagerDutyEscalationPolicyWithTeams_Basic
--- PASS: TestAccPagerDutyEscalationPolicyWithTeams_Basic (11.98s)
=== RUN   TestAccPagerDutySchedule_Basic
--- PASS: TestAccPagerDutySchedule_Basic (16.29s)
=== RUN   TestAccPagerDutySchedule_BasicWeek
--- PASS: TestAccPagerDutySchedule_BasicWeek (12.61s)
=== RUN   TestAccPagerDutySchedule_Multi
--- PASS: TestAccPagerDutySchedule_Multi (9.79s)
=== RUN   TestAccPagerDutyServiceIntegration_Basic
--- PASS: TestAccPagerDutyServiceIntegration_Basic (30.38s)
=== RUN   TestAccPagerDutyService_Basic
--- PASS: TestAccPagerDutyService_Basic (13.05s)
=== RUN   TestAccPagerDutyService_BasicWithIncidentUrgencyRules
--- PASS: TestAccPagerDutyService_BasicWithIncidentUrgencyRules (14.57s)
=== RUN   TestAccPagerDutyService_FromBasicToCustomIncidentUrgencyRules
--- PASS: TestAccPagerDutyService_FromBasicToCustomIncidentUrgencyRules (13.69s)
=== RUN   TestAccPagerDutyTeam_Basic
--- PASS: TestAccPagerDutyTeam_Basic (4.87s)
=== RUN   TestAccPagerDutyUser_Basic
--- PASS: TestAccPagerDutyUser_Basic (6.88s)
=== RUN   TestAccPagerDutyUserWithTeams_Basic
--- PASS: TestAccPagerDutyUserWithTeams_Basic (16.75s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/pagerduty	258.614s

@stack72 stack72 merged commit e72ac9f into hashicorp:master Feb 23, 2017
catsby added a commit that referenced this pull request Feb 23, 2017
* master: (499 commits)
  provider/aws: Fix the panic in ssm_association with parameters (#12215)
  Setting incident_urgency_rule as optional (#12211)
  Latest Section (#12151)
  provider/pagerduty: Import support for service integrations (#12141)
  command: fix test for new Meta type
  terraform: InstanceState.Meta is value type interface{}
  Update CHANGELOG.md
  flatmap: mark computed list as a computed value in Expand
  provider/azurerm: Bump AzureRM SDK to v8.0.1-beta (#11866)
  provider/profitbricks: fmt changes post cherry-pick
  provider/aws: Add missing SSM Links to documentation nav bar (#12202)
  update azure_network_interface documentation to say required for ip_configuration (#12185)
  Profitbricks primary nic fix (#12197)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  provider/aws: Lambda DeadLetterConfig support
  what was the value of the cluster id which caused the problem
  Corrected example code, cleared up token confusion (#12177)
  ...
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagerduty service incident_urgency_rule is non-optional
2 participants