provider/aws: Add KMS key tag support

[ewbankkit]

Add support for AWS KMS key tagging.
Acceptance test:

make testacc TEST=./builtin/providers/aws/ TESTARGS='-run=TestAccAWSKmsKey_tags'

Additional KMS API actions:

• ListResourceTags
• TagResource
• UntagResource

[ewbankkit]

Added acceptance test and rebased.

[stack72]

Hi @ewbankkit

What do you suggest we do about the permissions issue?

Paul

[ewbankkit]

@stack72 I would say just note in the CHANGELOG. The documentation doesn't currently state which IAM permissions are required for which resources and I'm sure this situation (additional attributes imply additional permissions) happens relatively frequently.
Maybe once you get to 1.0 we'll have to worry more about such changes.

[radeksimko]

Other than the error handling, this overall looks 👌 and I'm happy to merge it once that is addressed.

[radeksimko]

As mentioned in #12137 (comment) we should not be ignoring the error here. Instead to avoid confusions you can do something similar to what I did in #12759 - i.e. make the error message descriptive enough.

[ewbankkit]

Agreed. I'll try and fix that today.

[ewbankkit]

@radeksimko Made change as suggested (and rebased). I think the initial return nil was a typo for return err but still agree on better error message.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.