Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Change Port fixed_ip to a Set #12613

Merged
merged 1 commit into from
Mar 12, 2017

Conversation

jtopjian
Copy link
Contributor

This commit changes the openstack_networking_port_v2 fixed_ip
parameter from a List to a Set. This is because OpenStack does not
preserve the original ordering of the fixed IPs.

Fixes #12110

This commit changes the openstack_networking_port_v2 fixed_ip
parameter from a List to a Set. This is because OpenStack does not
preserve the original ordering of the fixed IPs.
@stack72
Copy link
Contributor

stack72 commented Mar 12, 2017

LGTM!

@stack72 stack72 merged commit 20c88bc into hashicorp:master Mar 12, 2017
stack72 pushed a commit that referenced this pull request Mar 12, 2017
This commit changes the openstack_networking_port_v2 fixed_ip
parameter from a List to a Set. This is because OpenStack does not
preserve the original ordering of the fixed IPs.
yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
This commit changes the openstack_networking_port_v2 fixed_ip
parameter from a List to a Set. This is because OpenStack does not
preserve the original ordering of the fixed IPs.
@sebastien-prudhomme
Copy link

Hi, this should be marked as a breaking change. All my configurations are broken as i use things like that:

resource "openstack_networking_port_v2" "myproject" {
  admin_state_up = "true"
  name           = myproject"
  network_id     = "${var.network_id}"

  security_group_ids = [
    "${var.secgroup_icmp_id}",
    "${var.secgroup_ssh_id}",
    "${var.secgroup_http_id}",
    "${var.secgroup_https_id}",
  ]
}

and later

myvalue = "${openstack_networking_port_v2.myproject.fixed_ip.0.ip_address}"

${openstack_networking_port_v2.myproject.fixed_ip.0.ip_address} is no more working and didn't find a way yet to access the unique fixed ip address automatically affected to the port.

@jtopjian
Copy link
Contributor Author

jtopjian commented Mar 17, 2017

@sebastien-prudhomme Yeah, that's a good point. I can see how this would have been used for situations where a single fixed IP was specified. This wouldn't have had consistent results with more than one fixed IP, though.

I think tracking down the fixed IP is a valid thing to do. I will look into how to best do this ASAP.

@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan shows changed on every run for my openstack_networking_port_v2
3 participants