provider/aws: Change Route 53 record to allow resource updates #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `ForceNew` from `records` and `ttl`, and introduces a `resourceAwsRoute53RecordUpdate` function. The `resourceAwsRoute53RecordUpdate` falls through to the `resourceAwsRoute53RecordCreate` function, which utilizes AWS `UPSERT` behavior and diffs for us. `Name` and `Type` are used by AWS in the `UPSERT`, so only records with matching `name` and `type` can be updated. Others are created as new, so we leave the `ForceNew` behavior here.
|
This should address #1122 |
|
LGTM 👍 Feel free to squash my comment typo fix commit or leave it. Either way works for me. 🐍 |
catsby
added a commit
that referenced
this pull request
Apr 8, 2015
provider/aws: Change Route 53 record to allow resource updates
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
ForceNewfromrecordsandttl, and introduces aresourceAwsRoute53RecordUpdatefunction. TheresourceAwsRoute53RecordUpdatefalls through to the
resourceAwsRoute53RecordCreatefunction, which utilizesAWS
UPSERTbehavior and diffs for us.NameandTypeare used by AWS in theUPSERT, so only records with matchingnameandtypecan be updated. Others are created as new, so we leave theForceNewbehavior here.