Implement Additional ELB Connection Attributes #1502
Conversation
| d.SetPartial("connection_draining") | ||
| d.SetPartial("connection_draining_timeout") | ||
| } | ||
|
|
There was a problem hiding this comment.
modifying both idle_timeout or connection_draining (and/or partner connection_draining_timeout) results in two ModifyLoadBalancerAttributes requests to AWS, but it looks like the API should support both of these in one request. Do you know if that's accurate?
There was a problem hiding this comment.
I wasn't sure on how to handle this, cross_zone_load_balancing does the same. I could do it all in one request if thats preferable. I order to do so I would just see if any of the ELB attributes supported keys are changed and then compose the call. Let me know if you want me to go that route and I will make the change.
There was a problem hiding this comment.
I suppose it depends on how AWS handles this on their side. I know for Route 53 for example you can get errors returned if you make a modification request while another modification request is still in-flight. If ELB are quicker, or don't do that at all, then it's just an optimization nice to have. But if for example changing both results in the latter failing, then obviously we need to avoid that. I'm OK leaving as is, assuming that is not the case.
|
Thanks for the contribution, very nice! Just a few questions for you, posted in-line |
| @@ -59,6 +62,9 @@ The following arguments are supported: | |||
| * `listener` - (Required) A list of listener blocks. Listeners documented below. | |||
| * `health_check` - (Optional) A health_check block. Health Check documented below. | |||
| * `cross_zone_load_balancing` - (Optional) Enable cross-zone load balancing. | |||
| * `idle_timeout` - (Optional) Adjust Idle Timeout. | |||
| * `connection_draining` - (Optional) Enable connection draining. | |||
| * `connection_draining_timeout` - (Optional) Adjust the timeout for connection draining. | |||
There was a problem hiding this comment.
It would be helpful to be more descriptive here.
idle_timeout: The time in seconds that the connection is allowed to be idle. Default: whatever the default isconnection_draining- (Optional) Boolean to enable connection draining.connection_draining_timeout- (Optional) The time in seconds to allow for connection draining. (or whatever)..
|
A few more follow ups, otherwise 👍 |
|
@catsby should be good to go. |
|
Thanks for answering our questions. This looks really good. And thanks a ton for the acceptance tests. That helps us verify this very easily. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
No description provided.