aws: Refactor credentials according to latest aws-sdk-go refactoring

[radeksimko]

AWS team recently refactored credentials in the upstream repo:
aws/aws-sdk-go@2910e59

This needs to be addressed in TF codebase too.

$ make test

go generate ./...
TF_ACC= go test ./...  -timeout=30s -parallel=4
# github.com/hashicorp/terraform/state/remote
state/remote/s3.go:35: undefined: aws.DetectCreds
FAIL    github.com/hashicorp/terraform [build failed]
# github.com/hashicorp/terraform/builtin/providers/aws
builtin/providers/aws/config.go:64: undefined: "github.com/awslabs/aws-sdk-go/aws".DetectCreds
ok      github.com/hashicorp/terraform/builtin/bins/provider-atlas  0.029s
FAIL    github.com/hashicorp/terraform/builtin/bins/provider-aws [build failed]
ok      github.com/hashicorp/terraform/builtin/bins/provider-cloudflare 0.028s
ok      github.com/hashicorp/terraform/builtin/bins/provider-cloudstack 0.021s
ok      github.com/hashicorp/terraform/builtin/bins/provider-consul 0.021s
ok      github.com/hashicorp/terraform/builtin/bins/provider-digitalocean   0.020s
ok      github.com/hashicorp/terraform/builtin/bins/provider-dme    0.025s
ok      github.com/hashicorp/terraform/builtin/bins/provider-dnsimple   0.023s
ok      github.com/hashicorp/terraform/builtin/bins/provider-docker 0.042s
ok      github.com/hashicorp/terraform/builtin/bins/provider-google 0.029s
ok      github.com/hashicorp/terraform/builtin/bins/provider-heroku 0.032s
ok      github.com/hashicorp/terraform/builtin/bins/provider-mailgun    0.026s
ok      github.com/hashicorp/terraform/builtin/bins/provider-null   0.033s
# github.com/hashicorp/terraform/builtin/providers/aws
builtin/providers/aws/config.go:64: undefined: "github.com/awslabs/aws-sdk-go/aws".DetectCreds
?       github.com/hashicorp/terraform/builtin/bins/provider-openstack  [no test files]
FAIL    github.com/hashicorp/terraform/builtin/bins/provider-terraform [build failed]
ok      github.com/hashicorp/terraform/builtin/bins/provisioner-file    0.034s
ok      github.com/hashicorp/terraform/builtin/bins/provisioner-local-exec  0.027s
ok      github.com/hashicorp/terraform/builtin/bins/provisioner-remote-exec 0.023s
ok      github.com/hashicorp/terraform/builtin/providers/atlas  0.020s
FAIL    github.com/hashicorp/terraform/builtin/providers/aws [build failed]
ok      github.com/hashicorp/terraform/builtin/providers/cloudflare 0.020s
ok      github.com/hashicorp/terraform/builtin/providers/cloudstack 0.029s
ok      github.com/hashicorp/terraform/builtin/providers/consul 0.019s
ok      github.com/hashicorp/terraform/builtin/providers/digitalocean   0.020s
ok      github.com/hashicorp/terraform/builtin/providers/dme    0.026s
ok      github.com/hashicorp/terraform/builtin/providers/dnsimple   0.036s
ok      github.com/hashicorp/terraform/builtin/providers/docker 0.032s
ok      github.com/hashicorp/terraform/builtin/providers/google 0.025s
ok      github.com/hashicorp/terraform/builtin/providers/heroku 0.029s
ok      github.com/hashicorp/terraform/builtin/providers/mailgun    0.020s
ok      github.com/hashicorp/terraform/builtin/providers/null   0.020s
ok      github.com/hashicorp/terraform/builtin/providers/openstack  0.025s
FAIL    github.com/hashicorp/terraform/builtin/providers/terraform [build failed]
ok      github.com/hashicorp/terraform/builtin/provisioners/file    0.037s
ok      github.com/hashicorp/terraform/builtin/provisioners/local-exec  0.034s
ok      github.com/hashicorp/terraform/builtin/provisioners/remote-exec 0.051s
FAIL    github.com/hashicorp/terraform/command [build failed]
ok      github.com/hashicorp/terraform/communicator 0.027s
ok      github.com/hashicorp/terraform/communicator/remote  0.012s
ok      github.com/hashicorp/terraform/communicator/ssh 0.465s
ok      github.com/hashicorp/terraform/communicator/winrm   0.051s
ok      github.com/hashicorp/terraform/config   0.119s
ok      github.com/hashicorp/terraform/config/lang  0.015s
ok      github.com/hashicorp/terraform/config/lang/ast  0.014s
ok      github.com/hashicorp/terraform/config/module    2.916s
ok      github.com/hashicorp/terraform/dag  0.016s
ok      github.com/hashicorp/terraform/depgraph 0.017s
ok      github.com/hashicorp/terraform/digraph  0.014s
?       github.com/hashicorp/terraform/dot  [no test files]
ok      github.com/hashicorp/terraform/flatmap  0.018s
ok      github.com/hashicorp/terraform/helper/config    0.034s
ok      github.com/hashicorp/terraform/helper/diff  0.034s
ok      github.com/hashicorp/terraform/helper/hashcode  0.024s
ok      github.com/hashicorp/terraform/helper/multierror    0.013s
# github.com/hashicorp/terraform/state/remote
state/remote/s3.go:35: undefined: aws.DetectCreds
state/remote/s3_test.go:54: s3Client.nativeClient.Service.Config.Credentials.Credentials undefined (type *credentials.Credentials has no field or method Credentials)
ok      github.com/hashicorp/terraform/helper/resource  1.450s
ok      github.com/hashicorp/terraform/helper/schema    0.059s
ok      github.com/hashicorp/terraform/helper/url   0.013s
ok      github.com/hashicorp/terraform/plugin   0.316s
ok      github.com/hashicorp/terraform/rpc  0.066s
ok      github.com/hashicorp/terraform/state    0.027s
FAIL    github.com/hashicorp/terraform/state/remote [build failed]
ok      github.com/hashicorp/terraform/terraform    0.630s
make: *** [test] Error 2

There doesn't seem to be DetectCreds functionality anymore (or maybe I just don't see it).
Isn't this the right time to look at #1049 ? 😺

cc @catsby

[pmoust]

#1801

[mitchellh]

Fixed up

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.