Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove security groups (by name) before adding security groups (by id) #2008

Merged
merged 1 commit into from
Sep 24, 2015
Merged

remove security groups (by name) before adding security groups (by id) #2008

merged 1 commit into from
Sep 24, 2015

Conversation

dupuy
Copy link
Contributor

@dupuy dupuy commented May 19, 2015

No description provided.

@dupuy
Copy link
Contributor Author

dupuy commented May 19, 2015

This is a partial fix (of the worst problems) that I reported in #2009. A good fix ought to do the security groups comparison by name or id, but that's a bit beyond my Terraform / Go hacking skills at the moment.

@jtopjian
Copy link
Contributor

I agree with everything you've done here and explained in #2009. This patch looks good to me and makes sense. I'll leave more comments in #2009.

@josephholsten
Copy link
Contributor

@phinze do you anything to merge this?

@phinze
Copy link
Contributor

phinze commented Sep 24, 2015

Sounds good to me - merging!

phinze added a commit that referenced this pull request Sep 24, 2015
remove security groups (by name) before adding security groups (by id)
@phinze phinze merged commit 50b8161 into hashicorp:master Sep 24, 2015
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants