provider/aws: Add support for ICMP Protocol in Network ACLs #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added icmp_type attribute - added icmp_code attribute - fixed an issue hiding the error
| * `icmp_type` - (Optional) The ICMP type to be used. Default 0. | ||
| * `icmp_code` - (Optional) The ICMP type code to be used. Default 0. | ||
|
|
||
| ~> Note: For more information on ICMP types and codes, see here: http://www.nthelp.com/icmp.html |
|
LGTM! |
catsby
added a commit
that referenced
this pull request
Jun 1, 2015
provider/aws: Add support for ICMP Protocol in Network ACLs
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icmp_typeattributeicmp_codeattributeI believe they way I've added them should be backwards compatible, e.g. people who aren't using this won't all of the sudden show changes to be made in
plan.AWS docs for this are here:
Should fix #2085