AWS Lambda functionality #2170
AWS Lambda functionality #2170
Conversation
cbednarski
commented
Jun 1, 2015
cbednarski
commented
- Includes documentation
- Includes acceptance tests
- Includes documentation - Includes acceptance tests
|
Reviewing now; looks like it needs a rebase though, do you have time? I can swoop in if you need |
|
|
||
| log.Printf("[DEBUG] Creating Lambda Function %s with role %s", functionName, iamRole) | ||
|
|
||
| zipfile, err := ioutil.ReadFile(d.Get("filename").(string)) |
There was a problem hiding this comment.
Does ioutil.ReadFile handle all the path expansion(s) we may need? e.g. does ~/some_path/file.zp also work?
There was a problem hiding this comment.
Nope! Good catch on this.
|
Some nitpick/comments, other than than 👍 |
|
Merged / updated with master to get the awslabs -> aws change. Lemme know if you want me to rebase. |
|
OH YEAH! |
|
💃 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
