Improve idempotency of aws_iam_server_certificate provisioning #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing AWS IAM SSL certificates
|
These changes would be very helpful. Thanks! |
|
Thanks for the PR and the great description. This looks solid! |
phinze
added a commit
that referenced
this pull request
Jun 22, 2015
Improve idempotency of aws_iam_server_certificate provisioning
|
kudos @Jberlinsky , the bug was causing some serious havoc on our ELBs! |
This was referenced Jul 28, 2015
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #2409. A brief recap follows:
When Terraform pulls down state data about AWS IAM certificates in its purview, it normalizes the certificate body by trimming whitespace from it and taking a SHA1 hash of the resulting string. This works well for dealing with newline characters at the end of a certificate, however, this logic does not apply to the certificate chain. A change to the certificate chain is enough for Terraform to rebuild the resource. The combination of these two circumstances means that, if one has an IAM certificate with a chain in their Terraform configuration,
terraform planwill always require some action, even if everything appears to be in sync.This pull request normalizes the certificate chain in the same way as the certificate body. While the major gains are in the use of
strings.TrimSpace, the SHA hashing is nice to have, as well. In passing, the integration test for this resource has been updated to include a self-signed certificate bearing a CA chain.