Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodb - Support backing off a bit when throttling / limit-exceeded exceptions happen #2462

Merged
merged 2 commits into from
Jun 25, 2015

Conversation

johnewart
Copy link
Contributor

Adds retrying creation of tables wth some back-off when an AWS ThrottlingException or LimitExceededException is thrown by the DynamoDB API

@catsby
Copy link
Contributor

catsby commented Jun 24, 2015

hey @johnewart – the SDK has some concept(s) of throttling builtin:

Is that something we could use here?

@johnewart
Copy link
Contributor Author

I didn't know there was any such thing, but I'll look at it; it would be preferable to use something built into the SDK

@johnewart
Copy link
Contributor Author

In looking at it the AWS SDK my understanding is that the auto-generated dynamodb service client would need to take advantage of those bits but it doesn't at the moment (it gets generated here: https://github.com/aws/aws-sdk-go/blob/master/internal/model/api/api.go#L224). Probably worth a stab at fixing that in the SDK at some point, so maybe I'll look at that later. Until that time, though, I think this is a reasonable solution.

@mitchellh
Copy link
Contributor

I'd be okay with merging this as a stop-gap, but can you report this upstream @johnewart?

I'll leave the review to you @catsby

@johnewart
Copy link
Contributor Author

Sure, I'll look at opening a ticket and possibly even put up some code for the SDK if needed because this seems to be something that should be built-in

@catsby
Copy link
Contributor

catsby commented Jun 25, 2015

Excellent, thanks all – merging

catsby added a commit that referenced this pull request Jun 25, 2015
dynamodb - Support backing off a bit when throttling / limit-exceeded exceptions happen
@catsby catsby merged commit de5df6f into hashicorp:master Jun 25, 2015
@ghost
Copy link

ghost commented May 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants