terraform: fail early if module validation fails #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if !computed { | ||
| t.Fatal("should be computed") | ||
| } | ||
| } |
There was a problem hiding this comment.
Why is this test going away?
There was a problem hiding this comment.
It was testing that validation didn't fail and that the validate resource function actually received a "computed" value in the case that a value wasn't specified. This happened prior to this commit, but not after. We were masking the error "variable 'foo' is required"
|
One question, but seems reasonable generally. |
mitchellh
added a commit
that referenced
this pull request
Jun 26, 2015
terraform: fail early if module validation fails
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1861
This just bails earlier if we have module validation errors. There isn't a test for this because its mostly a UX change. All errors that are caught at this stage are also caught at the graph stage, but the errors are nicer UX earlier if we bail.