provider/azure: Added SQL Database Server Firewall Rule resource. #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| d.SetId("name") |
There was a problem hiding this comment.
This should be SetId(name), otherwise every firewall rule will have the same ID. 😀
Might want to start with a failing acceptance test here by making a test case with two rules - I'd expect that to fail without fixing this.
There was a problem hiding this comment.
One of the brain farts I keep mentioning 😞
Fixed and updated tests 😄
aznashwan
force-pushed
the
f-azure-database-firewall
branch
2 times, most recently
from
f5c5904
to
0a055bd
Compare
aznashwan
force-pushed
the
f-azure-database-firewall
branch
from
0a055bd
to
7429027
Compare
|
LGTM! |
phinze
added a commit
that referenced
this pull request
Jun 29, 2015
provider/azure: Added SQL Database Server Firewall Rule resource.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility of applying firewall rules to database servers on Azure.
This patch contains all the afferent feature code alongside tests and documentation.
PS: also contains two minor fixes on the secgroup rules and databse service resources.
PPS: Special thanks to @svanharmelen for the good spot.