provider/aws: Add new resource - aws_vpc_endpoint

[radeksimko]

This is mostly @gjohnson 's work which I took and polished & added tests + docs.

The authorship the actual resource is still credited to you, @gjohnson 😉

This should help us to close the following:

• provider/aws: add support for vpc endpoint #2282
• Ignore vpc endpoint routes #2064
• Terraform panics on calculating diffs for route tables containing S3 VPC endpoint routes. #2063

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=VpcEndpoint' 2>/dev/null

go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=VpcEndpoint -timeout 90m
=== RUN TestAccVpcEndpoint_basic
--- PASS: TestAccVpcEndpoint_basic (7.55s)
=== RUN TestAccVpcEndpoint_withRouteTableAndPolicy
--- PASS: TestAccVpcEndpoint_withRouteTableAndPolicy (26.45s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    34.010s

I used normalizeJson from s3_bucket resource, do you want me to move it to a special file, so it's more obvious that it's not just used in s3_bucket? It feels a bit cleaner to do it, but it's still only a single function with a few lines.

[radeksimko]

I never understood what's the point of this construct which appears in most test*Exists helpers, it doesn't seem to do anything...

[phinze]

@radeksimko it's an "out parameter" - we store the endpoint in the provided pointer to allow subsequent checks to inspect the object

[radeksimko]

I see, but we don't do any subsequent checks in some places where this is used (including here), so is it just "code for the future" ™️ that we want to keep in place?

[radeksimko]

Answering to myself - I guess we should be checking attributes most of the time.

[phinze]

two tiny tiny nits. looking great! merge at will.

[radeksimko]

Fixed both and force-pushed, here's the diff:

diff --git a/builtin/providers/aws/resource_aws_route_table.go b/builtin/providers/aws/resource_aws_route_table.go
index a8a44e0..f6d6313 100644
--- a/builtin/providers/aws/resource_aws_route_table.go
+++ b/builtin/providers/aws/resource_aws_route_table.go
@@ -149,6 +149,8 @@ func resourceAwsRouteTableRead(d *schema.ResourceData, meta interface{}) error {
                }

                if r.DestinationPrefixListID != nil {
+                       // Skipping because VPC endpoint routes are handled separately
+                       // See aws_vpc_endpoint
                        continue
                }

diff --git a/builtin/providers/aws/resource_aws_vpc_endpoint.go b/builtin/providers/aws/resource_aws_vpc_endpoint.go
index 11c58ac..5617faa 100644
--- a/builtin/providers/aws/resource_aws_vpc_endpoint.go
+++ b/builtin/providers/aws/resource_aws_vpc_endpoint.go
@@ -133,8 +133,6 @@ func resourceAwsVPCEndpointUpdate(d *schema.ResourceData, meta interface{}) erro
        if d.HasChange("policy") {
                policy := normalizeJson(d.Get("policy"))
                input.PolicyDocument = aws.String(policy)
-       } else {
-               input.ResetPolicy = aws.Boolean(false)
        }

        log.Printf("[DEBUG] Updating VPC Endpoint: %#v", input)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.