provider/aws: Fix issue with checking for ElastiCache cluster status #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2015
|
Nice find! Totally makes sense why repro was tough in our test accounts - we rarely have multiple cache clusters floating around. |
| pending := []string{"creating"} | ||
| stateConf := &resource.StateChangeConf{ | ||
| Pending: pending, | ||
| Target: "available", | ||
| Refresh: cacheClusterStateRefreshFunc(conn, d.Id(), "available", pending), | ||
| Refresh: cacheClusterStateRefreshFunc(conn, *resp.CacheCluster.CacheClusterID, "available", pending), |
There was a problem hiding this comment.
Can leave this as d.Id() since you moved the SetId up, but not a huge deal either way
|
LGTM |
|
this worked great for me.. thanks for the fix |
* master: (33 commits) Update CHANGELOG.md Update CHANGELOG.md scripts: change website_push to push from HEAD update analytics provider/aws: Update source to comply with upstream breaking change Update CHANGELOG. provider/aws: Fix issue with IAM Server Certificates and Chains Increase timeout, IGM delete can be slow Make failure of "basic" test not interfere with success of "update" test Update CHANGELOG.md Use new autoscaler / instance group manager APIs. Compute private ip addresses of ENIs if they are not specified Update CHANGELOG.md Update CHANGELOG.md provider/aws: Error when unable to find a Root Block Device name Update CHANGELOG.md aws_db_instance: Add mixed-case engine test to ensure StateFunc works. aws_db_instance: Only write lowercase engines to the state file. Update CHANGELOG.md Split AWS provider topics by service. ...
catsby
added a commit
that referenced
this pull request
Jul 29, 2015
provider/aws: Fix issue with checking for ElastiCache cluster status
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're only checking the first Cache Cluster returned when we query the API to describe our clusters. If you have multiple clusters, you can falsely get a status of
available.waitForStatemethod without first setting the cluster id, so we were effectively grabbing all clusters by searching for"", not just a specific oneNow we set the id first, then enter the
waitForStatemethod. There we also filter the results for the specific Cluster. There should be only 1 returned, but I filter anyway.This should fix #2732 . Thanks to all in that issue, as well as #2051, for the help and patience.