Fix handling large states in the Consul backend #28838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckend Storing a state just a bit smaller than the limit of the KV API fails because we are using the Transaction API which has an overhead.
|
Hashicorp peeps, can someone take a look at this? |
jbardin
added
the
1.0-backport
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in e680211 to determine whether a given state is small enough to fit in a single KV entry in Consul is buggy: because we are using the Transaction API we are base64 encoding it so the payload sent is actually bigger than the raw state, and there is some JSON overhead. This fixes this issue by always trying to store the state in a single entry, and we split it if Consul tells us that is too large. Because we don't try to guess we don't fail anymore.
As far as I know no user as encountered this bug but this patch should be backported to the 0.14 branch as it was the first version to have this feature in the Consul backend.