backend/remote: Fix version check when migrating #29793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating state to an existing Terraform Cloud workspace using the remote backend, we check the remote version is compatible with the local one by default. This commit fixes two bugs in this code: - If using the "name" strategy for the remote backend, the list of destination workspaces is empty. This resulted in no version checking of the remote workspace, and we fell back to the string equality check. - The user-specified CLI flag `-ignore-remote-version` was not being applied for the state migration version checking.
alisdair
added
backend/remote
1.0-backport
nfagerlund
reviewed
Oct 21, 2021
|
Agreed, but I think the only useful way to test it would be an e2e test, which as far as I'm aware we don't have the machinery for (yet). |
chrisarcand
approved these changes
Oct 24, 2021
| // If there are no specified destination workspaces, perform a remote | ||
| // backend version check with the default workspace. | ||
| if len(destinationWorkspaces) == 0 { | ||
| diags := m.remoteBackendVersionCheck(opts.Destination, backend.DefaultStateName) |
There was a problem hiding this comment.
It took me far too long to follow the chain to verify this does the right thing with the default workspace. 😅
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating state to an existing Terraform Cloud workspace using the remote backend, we check the remote version is compatible with the local one by default.
This commit fixes two bugs in this code:
-ignore-remote-versionwas not being applied for the state migration version checking.Fixes #29789. Targeting 1.0 backport.