Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configs: fix ignore_changes config override bug #29849

Merged
merged 3 commits into from
Nov 1, 2021
Merged

configs: fix ignore_changes config override bug #29849

merged 3 commits into from
Nov 1, 2021

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Nov 1, 2021

Fixes #21474, in which ignore_changes = all does not survive a module merge.

@kmoe kmoe requested a review from a team November 1, 2021 19:10
alisdair
alisdair approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! ✅ We tend to add the label matching the package (i.e. config), and this might be worth considering for the 1.0-backport label workflow too.

@kmoe kmoe added config 1.0-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Nov 1, 2021
@kmoe kmoe merged commit ba4b665 into main Nov 1, 2021
@kmoe kmoe deleted the kmoe/ignore_changes-override branch November 1, 2021 19:54
@teamterraform teamterraform mentioned this pull request Nov 1, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alisdair alisdair alisdair approved these changes

Assignees
No one assigned
Labels
1.0-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override not working with ignore_changes
2 participants
@kmoe @alisdair