aws_kinesis_stream: shard_count state fix

[tphummel]

currently state always records shard_count as 1. this tests exposes
the issue in #2977

to run test:

export AWS_ACCESS_KEY_ID=...
export AWS_SECRET_ACCESS_KEY=...
make testacc TEST=./builtin/providers/aws TESTARGS='-run=KinesisStream'

output:

--- FAIL: TestAccAWSKinesisStream_basic (74.28s)
    testing.go:136: Step 0 error: Check failed: Bad Stream Shard Count
             expected: 2
            got: 1

FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    74.296s

[tphummel]

I cleaned up my branch. I believe this is ready to go and would love any feedback. More detail around the problem/solution is in #2977. Thanks!

[tphummel]

@catsby i know you are busy, but I would love to see this get into an upcoming release, assuming it is up to snuff. Any feedback or pointers would be greatly appreciated, I'm new to golang. Thank you!

[catsby]

Ah, I see the error in my ways 😦

Thanks for the patch! This checks out, I'm going to pull it it. Sorry for the delay

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.