-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore unexpanded paths when validating move statements. #30189
Conversation
fb73d90
to
e860428
Compare
instances.Set is only used after all instances have been processes, so it should therefor only handle known instances and not panic when given an address that traverses an unexpanded module.
e860428
to
b213386
Compare
I reviewed the source code of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense and i can confirm it fixes the error for the reproduction config i was able to create 👍🏼
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
After each plan, the entire set of known move blocks must be validated. Sometimes the individual addresses may lie outside of paths which are expanded during the plan, either through the use of
-target
, or later changes to the configuration that make themoved
obsolete.Since
instances.Set
is only used after all instances have been processed, it should only handle known instances and not panic when given an address that traverses an unexpanded module. This will allow for validation ofmoved
block which no longer apply to the current set of address to skip over addresses which cannot be expanded.Fixes #30196
Fixes #30184