provider/aws: add ses_smtp_password to iam_access_key #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS gives instructions for converting AWS credentials into SES SMTP credentials here: https://docs.aws.amazon.com/ses/latest/DeveloperGuide/smtp-credentials.html#smtp-credentials-convert This implements their algorithm and yields the result as an attribute on `iam_access_key`.
phinze
force-pushed
the
f-iam-smtp-password
branch
from
3673000
to
eb150ae
Compare
| if key == nil { | ||
| return "" | ||
| } | ||
| version := byte(0x02) |
There was a problem hiding this comment.
I don't think the byte cast is necessary, but if it helps for clarity purposes then 👍
There was a problem hiding this comment.
I think I'm going to leave it for verbosity's sake, but noted!
|
LGTM |
phinze
added a commit
that referenced
this pull request
Sep 3, 2015
provider/aws: add ses_smtp_password to iam_access_key
marothstein
reviewed
Jul 12, 2019
| @@ -55,5 +55,8 @@ The following attributes are exported: | |||
| * `id` - The access key ID. | |||
| * `user` - The IAM user associated with this access key. | |||
| * `secret` - The secret access key. Note that this will be written to the state file. | |||
| * `ses_smtp_password` - The secret access key converted into an SES SMTP | |||
There was a problem hiding this comment.
At this point, shouldn't this be encrypted with PGP in the same way the secret is?
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS gives instructions for converting AWS credentials into SES SMTP
credentials here:
https://docs.aws.amazon.com/ses/latest/DeveloperGuide/smtp-credentials.html#smtp-credentials-convert
This implements their algorithm and yields the result as an attribute on
iam_access_key.