Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/s3: Add allowed_account_ids and forbidden_account_ids parameters #33688

Closed
Tracked by #33687
gdavison opened this issue Aug 15, 2023 · 2 comments · Fixed by #33805
Closed
Tracked by #33687

backend/s3: Add allowed_account_ids and forbidden_account_ids parameters #33688

gdavison opened this issue Aug 15, 2023 · 2 comments · Fixed by #33805
Assignees
Labels
backend/s3 enhancement new new issue not yet triaged

Comments

@gdavison
Copy link
Contributor

Terraform Version

N/A

Use Cases

Adding allowed_account_ids and forbidden_account_ids parameters will allow restricting accounts. This will add parity with the AWS Provider

Attempted Solutions

N/A

Proposal

No response

References

No response

@jar-b
Copy link
Member

jar-b commented Aug 30, 2023

These config arguments (and the corresponding logic) are currently only defined in the AWS provider.

https://github.com/hashicorp/terraform-provider-aws/blob/824f4d9172e86218973a3e997566d725c3a5429e/internal/conns/config.go#L27
https://github.com/hashicorp/terraform-provider-aws/blob/824f4d9172e86218973a3e997566d725c3a5429e/internal/conns/config.go#L170-L188

It may make sense to move this down into aws-sdk-go-base V2 so the logic can be shared between the AWS Provider and S3 backend.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend/s3 enhancement new new issue not yet triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants