Aws glacier resource merge

[stack72]

@radeksimko This is the clean PR of #3169

This has the rebased commits

Thanks to @mat-mcloughlin for the git help here :)

From the old PR description:

---

Started to build the resource to create an AWS Glacier Vault

Please note that I am pretty new to Go and this will take a little while to complete while I learn more about it

• Resource for Vault Management
• Documentation
• Acceptance Tests

I have added a few basic acceptance tests:

terraform [aws-glacier-resource●●] % make testacc TEST=./builtin/providers/aws TESTARGS='-run=GlacierVault' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=GlacierVault -timeout 90m
=== RUN TestAccAWSGlacierVault_basic
--- PASS: TestAccAWSGlacierVault_basic (3.31s)
=== RUN TestAccAWSGlacierVault_full
--- PASS: TestAccAWSGlacierVault_full (3.40s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    6.718s

[radeksimko]

Awesome, it wasn't necessary to create a new PR (it is possible to rebase a branch that is part of the existing PR), but it still makes my life a lot easier. 👍 😃

There's a tiny issue reproducible w/ the example from docs:

~ aws_glacier_vault.my_archive
    access_policy: "{\"Statement\":[{\"Action\":[\"glacier:InitiateJob\",\"glacier:GetJobOutput\"],\"Effect\":\"Allow\",\"Principal\":\"*\",\"Resource\":\"arn:aws:glacier:us-west-2:287636751237:vaults/MyArchive\",\"Sid\":\"add-read-only-perm\"}],\"Version\":\"2012-10-17\"}" => "{\"Statement\":[{\"Action\":[\"glacier:InitiateJob\",\"glacier:GetJobOutput\"],\"Effect\":\"Allow\",\"Principal\":\"*\",\"Resource\":[\"arn:aws:glacier:us-west-2:287636751237:vaults/MyArchive\"],\"Sid\":\"add-read-only-perm\"}],\"Version\":\"2012-10-17\"}"

but that should be solved on a higher level anyway, so I think it's 👌 to merge this now. I will modify the example slightly after merging, so at least people don't bump into it straight from there.

Data retrieval rules can also be added later on.

[stack72]

@radeksimko my branch got into a lot of trouble so was easy to rebase and cherry-pick :)

I will have a look at what else can be added to the glacier resource

Thanks for the merge

P.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.