provider/aws: add aws_route resource (finish)

[BSick7]

This work completes, rebases, and squashes work from #2454.

[BSick7]

@catsby @phinze This is ready for review based on previous PR that was incomplete.

[gkze]

Thank you @BSick7 🙏

[pll]

Great to see this wrapping up. Any idea how long until we see it in a release?

[sarguru]

Thanks @BSick7 would really love to have this

[pll]

Looking through the code and seeing the example usage, I don't see a way to add route-propagation to this. Currently I'm doing this:

resource "aws_route_table" "private-route-table" {
   vpc_id = "${var.vpc_id}"
   route {
       # Default route via the NAT
       cidr_block  = "0.0.0.0/0"
       instance_id = "${var.nat_id}"
   }
   route {
       # Datacenter traffic via the VGW
       cidr_block  = "${var.datacenter_cidr}"
       gateway_id  = "${var.vgw_id}"
   }
   # Make sure to propagate the VGW routes
   propagating_vgws = ["${var.vgw_id}"]
}

I'd really like to create the route initially like this:

resource "aws_route_table" "private-route-table" {
   vpc_id = "${var.vpc_id}"
   route {
       # Default route via the NAT
       cidr_block  = "0.0.0.0/0"
       instance_id = "${var.nat_id}"
   }
}

Then add a route later like this:

resource "aws_route" "priv-rt" {
  route_table_id   = "${var.privrt_id}"
  destination_cidr_block = "${var.datacenter_cidr}"
  gateway_id  = "${var.vgw_id}"

   # Make sure to propagate the VGW routes
   propagating_vgws = ["${var.vgw_id}"]
}

Does this make sense ?

[BSick7]

@pll propagating_vgws belongs to a route table. propagating_vgws has no meaning directly attached to aws_route.

Keep in mind, this PR also does not implement mixed mode route tables (inline routes and singular aws_route resources). In #2454, there was a dialogue discussing alternative ways of solving through https://github.com/hashicorp/terraform/issues/2275.

[pll]

@BSick7 - Yeah, I get that the propagating_vgws isn't directly connected to adding a route in the aws_route resource. What I was trying to convey is that in this case, when I add a route of this type, I also want to toggle the propagation from off to on. That action is associated with the addition of this type of route, which means when I employ the aws_route resource, I also need a means up updating the route_table resource for propagating_vgws as well.

It might be solvable with #2275, I'm not sure. Or maybe something analagous to an aws_update_route_table feature.

Thanks

[BSick7]

@pll propagation of a vgw within an aws_route is more of a status than a configuration point. Note that http://docs.aws.amazon.com/sdk-for-go/api/service/ec2/EC2.html#CreateRoute-instance_method does not allow this type of input.

[pll]

@BSick7 - Interesting. So, really all I need is a way to access client.EnableVgwRoutePropagationRequest(params) from within terraform it seems.

[BSick7]

@pll correct. That api would tie into aws_route_table.

[catsby]

should just be aws_route, right? Same for sidebar_current

[BSick7]

Yup! Fixing.

[catsby]

A few questions, otherwise very promising. Thanks!

[BSick7]

@catsby I removed the code doing a recreate and used ForceNew. The acceptance tests still pass locally.

[BSick7]

@catsby any plans to review this soon?

[catsby]

Thanks for the updates, @BSick7 . This looks good, pulling it in

[steve-jansen]

🚀

[antonosmond]

Awesome!!! Well done guys there's a lot of us that have been waiting for this for sooooo long! I hope the next terraform release is very soon!

[ryedin]

Oh boy oh boy :) - also waiting with baited breath for this release! This is the only thing keeping us from realizing a fully automated workflow right now.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.