Add support for unary operators + and - to the interpolation syntax #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszwedko
changed the title
|
This LGTM - but I'd like to get @mitchellh's eyes on it too. |
This adds support to the configuration interpolation syntax for + and - as unary operators, specifically to represent negative numbers.
jszwedko
force-pushed
the
add-support-for-negative-literals
branch
from
c141167
to
41f9ebc
Compare
|
Rebased to get mergeable again. Let me know what you think @mitchellh. |
|
This all LGTM. Great job. |
|
👍 |
phinze
added a commit
that referenced
this pull request
Dec 18, 2015
Add support for unary operators + and - to the interpolation syntax
VladRassokhin
referenced
this pull request
in hashicorp/hil
Mar 5, 2016
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the configuration interpolation syntax for + and -
as unary operators, specifically to represent negative numbers.
This is the first time I've touched the AST code, so I'm sure that I did something wrong.