Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add notification topic ARN for ElastiCache clusters (continuation from #2836) #3674

Merged
merged 3 commits into from
Oct 28, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Oct 28, 2015

Supersedes #2836 by adding a test for the added notification_topic_arn attribute

thegedge and others added 3 commits September 22, 2015 15:49
* master: (335 commits)
  Update CHANGELOG.md
  config: return to the go1.5 generated lang/y.go
  Update CHANGELOG.md
  Allow cluster name, not only ARN for aws_ecs_service
  Update CHANGELOG.md
  Add check errors on reading CORS rules
  Update CHANGELOG.md
  website: docs for null_resource
  dag: use hashcodes to as map key to edge sets
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  Use hc-releases
  provider/google: Added scheduling block to compute_instance
  Use vendored fastly logo
  Use releases for releases
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update vpn.tf
  Update CHANGELOG.md
  ...
@catsby catsby changed the title Pr 2836 provider/aws: Add notification topic ARN for ElastiCache clusters (continuation from #2836) Oct 28, 2015
@catsby
Copy link
Contributor Author

catsby commented Oct 28, 2015

Merging as this is a continuation of work that I've approved, and just added a test too

catsby added a commit that referenced this pull request Oct 28, 2015
provider/aws: Add notification topic ARN for ElastiCache clusters (continuation from #2836)
@catsby catsby merged commit 191b6c8 into master Oct 28, 2015
@radeksimko radeksimko deleted the pr-2836 branch October 29, 2015 09:42
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants